Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds copy for the name of a shortcut to reopen current tab in a specific container #31

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds copy for the name of a shortcut to reopen current tab in a specific container #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,6 +419,15 @@
}
}
},
"reopenInContainerShortcut": {
"message": "Reopen in Container $keyId$",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why "Container" uppercase?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast feedback @flodolo

"Container" is capitalized to indicate that it is a significant term within the application.
Also it is capitalized in most of the cases across the file.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right 🤔 (there are 5 of them with lowercase container though).

Keeping this one open until there is agreement in the main code repository.

"description": "The keyboard shortcut description for reopening current tab in container number $keyId$",
"placeholders": {
"keyId": {
"content": "$1"
}
}
},
"openBookmarkInContainerTab": {
"message": "Open Bookmark in Container Tab"
},
Expand Down