adds copy for the name of a shortcut to reopen current tab in a specific container #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
flodolo
reviewed
Feb 21, 2025
| @@ -419,6 +419,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "reopenInContainerShortcut": { | |||
| "message": "Reopen in Container $keyId$", | |||
There was a problem hiding this comment.
Why "Container" uppercase?
There was a problem hiding this comment.
Thanks for the fast feedback @flodolo
"Container" is capitalized to indicate that it is a significant term within the application.
Also it is capitalized in most of the cases across the file.
There was a problem hiding this comment.
You're right 🤔 (there are 5 of them with lowercase container though).
Keeping this one open until there is agreement in the main code repository.
flodolo
approved these changes
Feb 21, 2025
| @@ -419,6 +419,15 @@ | |||
| } | |||
| } | |||
| }, | |||
| "reopenInContainerShortcut": { | |||
| "message": "Reopen in Container $keyId$", | |||
There was a problem hiding this comment.
You're right 🤔 (there are 5 of them with lowercase container though).
Keeping this one open until there is agreement in the main code repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needed for this mozilla/multi-account-containers#2721
reopen.in.container.with.shortcut.mov