Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds the required strings for sort tabs confirmation panel #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

adds the required strings for sort tabs confirmation panel #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions en/messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,12 @@
"showThisContainer": {
"message": "Show This Container"
},
"sortTabs":{
"message" : "sort tabs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this starting lower case? Please add a description to these strings, and consider having a more meaningful string ID (is it a button? Then sortTabsButton would be better).

Can you provide a screenshot?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure
Screenshot 2025-02-18 124428
i was trying to add a confirmation panel before sorting tabs

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The lowercase "sort" doesn't make a lot of sense to me. Does this need a title, since there is already one above?

@dannycolin
What kind of support or process do you have for content/UX at this point?

},
"sortTabsConfirmation": {
"message": "Are you sure you want to sort all tabs?"
},
"removeThisContainer": {
"message": "Remove This Container"
},
Expand Down