adds the required strings for sort tabs confirmation panel #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
requested changes
Feb 17, 2025
| @@ -117,6 +117,12 @@ | |||
| "showThisContainer": { | |||
| "message": "Show This Container" | |||
| }, | |||
| "sortTabs":{ | |||
| "message" : "sort tabs" | |||
There was a problem hiding this comment.
Why is this starting lower case? Please add a description to these strings, and consider having a more meaningful string ID (is it a button? Then sortTabsButton would be better).
Can you provide a screenshot?
There was a problem hiding this comment.
sure
i was trying to add a confirmation panel before sorting tabs
There was a problem hiding this comment.
The lowercase "sort" doesn't make a lot of sense to me. Does this need a title, since there is already one above?
@dannycolin
What kind of support or process do you have for content/UX at this point?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title: Add English locale strings
Description:
This PR adds the necessary English locale strings to the en/ folder. No other locales were modified. The changes ensure proper localization for the extension.