Move std-analysis.sh script from Kani repository #261
Conversation
Copied from model-checking/kani@8d46dc61d89b8b1cb8a with the change that the generated Cargo.toml is forced to edition2024 support to make it work with Rust releases after 2025-02-26.
Added to verify-rust-std in model-checking/verify-rust-std#261.
There was a problem hiding this comment.
Are we moving it from the Kani repo to achieve some new functionality, or do we just think it makes more sense for it to live here? (I am fine with the latter, I just want to make sure I understand the purpose of the move).
Once this PR is approved by another reviewer, can you open a PR to remove it from Kani? I'd like to avoid having it in two places in case we ever make further updates to it. Ah, I see you already did that.
It seems to make more sense to have it here, and the main reason I am doing this now is that the metrics in this repository are currently broken, the fix for which would have required making a change in the Kani repository (even though the fix is unrelated to Kani), and even with that change it wouldn't have helped as we would further have had to update the version of Kani that this repository uses as well. These cross-repository dependencies just didn't seem appropriate anymore. |
| fi | ||
| cargo new std_lib_analysis --lib | ||
| cd std_lib_analysis | ||
| sed -i '1i cargo-features = ["edition2024"]' Cargo.toml |
There was a problem hiding this comment.
Can this be replaced by adding --edition 2024 to the cargo new command?
Copied from model-checking/kani@8d46dc61d89b8b1cb8a with the change that the generated Cargo.toml is forced to edition2024 support to make it work with Rust releases after 2025-02-26. This will re-enable successfully gathering metrics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.