forked from rust-lang/rust
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track metrics for core
and std
crates, add loop metrics
#258
Open
tautschnig
wants to merge
5
commits into
model-checking:main
Choose a base branch
from
tautschnig:metrics-std
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The crate that we compute metrics for is now configurable when invoking `kani_std_analysis.py`. Should we find a need for further crates beyond `core` or `std` we just need to invoke it more times.
carolynzech
requested changes
Feb 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
core
and std
cratescore
and std
cratess, add loop metrics
carolynzech
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We might want #261 to be merged first and we need model-checking/kani#3915 to be merged. |
core
and std
cratess, add loop metricscore
and std
crates, add loop metrics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The crate that we compute metrics for is now configurable when invoking
kani_std_analysis.py
. Should we find a need for further crates beyondcore
orstd
we just need to invoke it more times.We are now also reporting loop/no-loop information across all the kinds of functions we are tracking as metrics.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.