test: vaults fuzzing

.github/CODEOWNERS

@@ -1,7 +1,3 @@
 # CODEOWNERS: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners
-
-# Any PR to `master` branch with changes to production contracts notifies the protocol team
-/contracts/ @lidofinance/lido-eth-protocol
-
-# Any PR to `master` branch with changes to GitHub workflows notifies the workflow review team
-/.github/workflows/ @lidofinance/review-gh-workflows
+* @lidofinance/lido-eth-protocol
+.github @lidofinance/review-gh-workflows

.github/workflows/tests-integration-mainnet.yml

@@ -1,30 +1,34 @@
 name: Integration Tests
-#on: [push]
-#
-#jobs:
-#  test_hardhat_integration_fork:
-#    name: Hardhat / Mainnet
-#    runs-on: ubuntu-latest
-#    timeout-minutes: 120
-#
-#    services:
-#      hardhat-node:
-#        image: ghcr.io/lidofinance/hardhat-node:2.22.18
-#        ports:
-#          - 8545:8545
-#        env:
-#          ETH_RPC_URL: "${{ secrets.ETH_RPC_URL }}"
-#
-#    steps:
-#      - uses: actions/checkout@v4
-#
-#      - name: Common setup
-#        uses: ./.github/workflows/setup
-#
-#      - name: Set env
-#        run: cp .env.example .env
-#
-#      - name: Run integration tests
-#        run: yarn test:integration:fork:mainnet
-#        env:
-#          LOG_LEVEL: debug
+
+on:
+  push:
+  schedule:
+    - cron: "0 10 */2 * *"
+
+jobs:
+  test_hardhat_integration_fork:
+    name: Hardhat / Mainnet
+    runs-on: ubuntu-latest
+    timeout-minutes: 120
+
+    services:
+      hardhat-node:
+        image: ghcr.io/lidofinance/hardhat-node:2.22.17
+        ports:
+          - 8545:8545
+        env:
+          ETH_RPC_URL: "${{ secrets.ETH_RPC_URL }}"
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Common setup
+        uses: ./.github/workflows/setup
+
+      - name: Set env
+        run: cp .env.example .env
+
+      - name: Run integration tests
+        run: yarn test:integration:fork:mainnet
+        env:
+          LOG_LEVEL: debug

.gitignore

@@ -25,6 +25,7 @@ lib/abi/*.json
 accounts.json
 deployed-local.json
 deployed-hardhat.json
+deployed-local-devnet.json
 
 # MacOS
 .DS_Store

deployed-holesky.json

@@ -175,7 +175,7 @@
   "app:simple-dvt": {
     "stakingRouterModuleParams": {
       "moduleName": "SimpleDVT",
-      "moduleType": "simple-dvt-onchain-v1",
+      "moduleType": "curated-onchain-v1",
       "targetShare": 50,
       "moduleFee": 800,
       "treasuryFee": 200,

foundry.toml

@@ -15,7 +15,7 @@ test = 'test'
 cache = true
 
 # The cache directory if enabled
-cache_path  = 'foundry/cache'
+cache_path = 'foundry/cache'
 
 # Only run tests in contracts matching the specified glob pattern
 match_path = '**/test/**/*.t.sol'

globals.d.ts

@@ -39,7 +39,6 @@ declare namespace NodeJS {
     LOCAL_KERNEL_ADDRESS?: string;
     LOCAL_LEGACY_ORACLE_ADDRESS?: string;
     LOCAL_LIDO_ADDRESS?: string;
-    LOCAL_WSTETH_ADDRESS?: string;
     LOCAL_NOR_ADDRESS?: string;
     LOCAL_ORACLE_DAEMON_CONFIG_ADDRESS?: string;
     LOCAL_ORACLE_REPORT_SANITY_CHECKER_ADDRESS?: string;
@@ -48,7 +47,6 @@ declare namespace NodeJS {
     LOCAL_VALIDATORS_EXIT_BUS_ORACLE_ADDRESS?: string;
     LOCAL_WITHDRAWAL_QUEUE_ADDRESS?: string;
     LOCAL_WITHDRAWAL_VAULT_ADDRESS?: string;
-    LOCAL_STAKING_VAULT_FACTORY_ADDRESS?: string;
 
     /* for mainnet fork testing */
     MAINNET_RPC_URL: string;
@@ -65,7 +63,6 @@ declare namespace NodeJS {
     MAINNET_KERNEL_ADDRESS?: string;
     MAINNET_LEGACY_ORACLE_ADDRESS?: string;
     MAINNET_LIDO_ADDRESS?: string;
-    MAINNET_WSTETH_ADDRESS?: string;
     MAINNET_NOR_ADDRESS?: string;
     MAINNET_ORACLE_DAEMON_CONFIG_ADDRESS?: string;
     MAINNET_ORACLE_REPORT_SANITY_CHECKER_ADDRESS?: string;
@@ -74,17 +71,14 @@ declare namespace NodeJS {
     MAINNET_VALIDATORS_EXIT_BUS_ORACLE_ADDRESS?: string;
     MAINNET_WITHDRAWAL_QUEUE_ADDRESS?: string;
     MAINNET_WITHDRAWAL_VAULT_ADDRESS?: string;
-    MAINNET_STAKING_VAULT_FACTORY_ADDRESS?: string;
-
-    HOLESKY_RPC_URL?: string;
-    SEPOLIA_RPC_URL?: string;
-    MEKONG_RPC_URL?: string;
 
     /* for contract sourcecode verification with `hardhat-verify` */
     ETHERSCAN_API_KEY?: string;
-    BLOCKSCOUT_API_KEY?: string;
 
-    /* Scratch deploy environment variables */
-    NETWORK_STATE_FILE?: string;
+    /* for local devnet */
+    LOCAL_DEVNET_PK?: string;
+    LOCAL_DEVNET_CHAIN_ID?: string;
+    LOCAL_DEVNET_EXPLORER_API_URL?: string;
+    LOCAL_DEVNET_EXPLORER_URL?: string;
   }
 }

hardhat.config.ts

@@ -11,7 +11,6 @@ import "hardhat-tracer";
 import "hardhat-watcher";
 import "hardhat-ignore-warnings";
 import "hardhat-contract-sizer";
-import "hardhat-gas-reporter";
 import { HardhatUserConfig } from "hardhat/config";
 
 import { mochaRootHooks } from "test/hooks";
@@ -22,12 +21,22 @@ import { getHardhatForkingConfig, loadAccounts } from "./hardhat.helpers";
 
 const RPC_URL: string = process.env.RPC_URL || "";
 
+export const ZERO_PK = "0x0000000000000000000000000000000000000000000000000000000000000000";
+
 const config: HardhatUserConfig = {
   defaultNetwork: "hardhat",
-  gasReporter: {
-    enabled: process.env.SKIP_GAS_REPORT ? false : true,
-  },
   networks: {
+    "local": {
+      url: process.env.LOCAL_RPC_URL || RPC_URL,
+    },
+    "local-devnet": {
+      url: process.env.LOCAL_RPC_URL || RPC_URL,
+      accounts: [process.env.LOCAL_DEVNET_PK || ZERO_PK],
+    },
+    "mainnet-fork": {
+      url: process.env.MAINNET_RPC_URL || RPC_URL,
+      timeout: 20 * 60 * 1000, // 20 minutes
+    },
     "hardhat": {
       // setting base fee to 0 to avoid extra calculations doesn't work :(
       // minimal base fee is 1 for EIP-1559
@@ -43,30 +52,32 @@ const config: HardhatUserConfig = {
       },
       forking: getHardhatForkingConfig(),
     },
-    "local": {
-      url: process.env.LOCAL_RPC_URL || RPC_URL,
-    },
-    "holesky": {
-      url: process.env.HOLESKY_RPC_URL || RPC_URL,
-      chainId: 17000,
-      accounts: loadAccounts("holesky"),
-    },
     "sepolia": {
-      url: process.env.SEPOLIA_RPC_URL || RPC_URL,
+      url: RPC_URL,
       chainId: 11155111,
       accounts: loadAccounts("sepolia"),
     },
     "sepolia-fork": {
       url: process.env.SEPOLIA_RPC_URL || RPC_URL,
       chainId: 11155111,
     },
-    "mainnet-fork": {
-      url: process.env.MAINNET_RPC_URL || RPC_URL,
-      timeout: 20 * 60 * 1000, // 20 minutes
-    },
   },
   etherscan: {
-    apiKey: process.env.ETHERSCAN_API_KEY || "",
+    customChains: [
+      {
+        network: "local-devnet",
+        chainId: parseInt(process.env.LOCAL_DEVNET_CHAIN_ID ?? "32382", 10),
+        urls: {
+          apiURL: process.env.LOCAL_DEVNET_EXPLORER_API_URL ?? "",
+          browserURL: process.env.LOCAL_DEVNET_EXPLORER_URL ?? "",
+        },
+      },
+    ],
+    apiKey: process.env.LOCAL_DEVNET_EXPLORER_API_URL
+      ? {
+          "local-devnet": "local-devnet",
+        }
+      : process.env.ETHERSCAN_API_KEY || "",
   },
   solidity: {
     compilers: [
@@ -120,16 +131,6 @@ const config: HardhatUserConfig = {
           evmVersion: "istanbul",
         },
       },
-      {
-        version: "0.8.25",
-        settings: {
-          optimizer: {
-            enabled: true,
-            runs: 200,
-          },
-          evmVersion: "cancun",
-        },
-      },
     ],
   },
   tracer: {
@@ -144,10 +145,7 @@ const config: HardhatUserConfig = {
   },
   watcher: {
     test: {
-      tasks: [
-        { command: "compile", params: { quiet: true } },
-        { command: "test", params: { noCompile: true, testFiles: ["{path}"] } },
-      ],
+      tasks: [{ command: "test", params: { testFiles: ["{path}"] } }],
       files: ["./test/**/*"],
       clearOnStart: true,
       start: "echo Running tests...",
@@ -174,7 +172,7 @@ const config: HardhatUserConfig = {
   contractSizer: {
     alphaSort: false,
     disambiguatePaths: false,
-    runOnCompile: process.env.SKIP_CONTRACT_SIZE ? false : true,
+    runOnCompile: true,
     strict: true,
     except: ["template", "mocks", "@aragon", "openzeppelin", "test"],
   },

lib/deploy.ts

@@ -5,7 +5,7 @@ import { FactoryOptions } from "hardhat/types";
 import { LidoLocator } from "typechain-types";
 
 import { addContractHelperFields, DeployedContract, getContractPath, loadContract, LoadedContract } from "lib/contract";
-import { ConvertibleToString, cy, gr, log, yl } from "lib/log";
+import { ConvertibleToString, cy, log, yl } from "lib/log";
 import { incrementGasUsed, Sk, updateObjectInState } from "lib/state-file";
 
 const GAS_PRIORITY_FEE = process.env.GAS_PRIORITY_FEE || null;
@@ -36,15 +36,11 @@ export async function makeTx(
   log.withArguments(`Call: ${yl(contract.name)}[${cy(contract.address)}].${yl(funcName)}`, args);
 
   const tx = await contract.getFunction(funcName)(...args, txParams);
-  log(` Transaction: ${tx.hash} (nonce ${yl(tx.nonce)})...`);
 
   const receipt = await tx.wait();
   const gasUsed = receipt.gasUsed;
   incrementGasUsed(gasUsed, withStateFile);
 
-  log(` Executed (gas used: ${yl(gasUsed)})`);
-  log.emptyLine();
-
   return receipt;
 }
 
@@ -80,8 +76,6 @@ async function deployContractType2(
     throw new Error(`Failed to send the deployment transaction for ${artifactName}`);
   }
 
-  log(` Transaction: ${tx.hash} (nonce ${yl(tx.nonce)})`);
-
   const receipt = await tx.wait();
   if (!receipt) {
     throw new Error(`Failed to wait till the transaction ${tx.hash} execution!`);
@@ -92,9 +86,6 @@ async function deployContractType2(
   (contract as DeployedContract).deploymentGasUsed = gasUsed;
   (contract as DeployedContract).deploymentTx = tx.hash;
 
-  log(` Deployed: ${gr(receipt.contractAddress!)} (gas used: ${yl(gasUsed)})`);
-  log.emptyLine();
-
   await addContractHelperFields(contract, artifactName);
 
   return contract as DeployedContract;

lib/index.ts

@@ -21,7 +21,5 @@ export * from "./signing-keys";
 export * from "./state-file";
 export * from "./string";
 export * from "./time";
-export * from "./transaction";
-export * from "./type";
 export * from "./units";
 export * from "./deposit";

lib/log.ts

@@ -1,8 +1,6 @@
 import chalk from "chalk";
 import path from "path";
 
-import { TraceableTransaction } from "./type";
-
 // @ts-expect-error TS2339: Property 'toJSON' does not exist on type 'BigInt'.
 BigInt.prototype.toJSON = function () {
   return this.toString();
@@ -127,24 +125,3 @@ log.debug = (title: string, records: Record<string, ConvertibleToString>) => {
   Object.keys(records).forEach((label) => _record(`  ${label}`, records[label]));
   log.emptyLine();
 };
-
-log.traceTransaction = (name: string, tx: TraceableTransaction) => {
-  const value = tx.value === "0.0" ? "" : `Value: ${yl(tx.value)} ETH`;
-  const from = `From: ${yl(tx.from)}`;
-  const to = `To: ${yl(tx.to)}`;
-  const gasPrice = `Gas price: ${yl(tx.gasPrice)} gwei`;
-  const gasLimit = `Gas limit: ${yl(tx.gasLimit)}`;
-  const gasUsed = `Gas used: ${yl(tx.gasUsed)} (${yl(tx.gasUsedPercent)})`;
-  const block = `Block: ${yl(tx.blockNumber)}`;
-  const nonce = `Nonce: ${yl(tx.nonce)}`;
-
-  const color = tx.status ? gr : rd;
-  const status = `${color(name)} ${color(tx.status ? "confirmed" : "failed")}`;
-
-  log(`Transaction sent:`, yl(tx.hash));
-  log(`   ${from}   ${to}   ${value}`);
-  log(`   ${gasPrice}   ${gasLimit}   ${gasUsed}`);
-  log(`   ${block}   ${nonce}`);
-  log(`   ${status}`);
-  log.emptyLine();
-};