test: vaults fuzzing #918

sergeyWh1te · 2025-01-10T14:42:18Z

Test shareRate with fuzzing

…e scratch deploy

github-actions · 2025-01-10T14:46:01Z

Hardhat Unit Tests Coverage Summary

Filename                                                       Stmts    Miss  Cover    Missing
-----------------------------------------------------------  -------  ------  -------  ------------------------------------------------------------------------------
contracts/0.4.24/Lido.sol                                        201       6  97.01%   741, 746, 787-789, 946-947
contracts/0.4.24/StETH.sol                                        79       0  100.00%
contracts/0.4.24/StETHPermit.sol                                  15       0  100.00%
contracts/0.4.24/lib/Packed64x4.sol                                5       0  100.00%
contracts/0.4.24/lib/SigningKeys.sol                              36       0  100.00%
contracts/0.4.24/lib/StakeLimitUtils.sol                          37       0  100.00%
contracts/0.4.24/nos/NodeOperatorsRegistry.sol                   512       0  100.00%
contracts/0.4.24/oracle/LegacyOracle.sol                          72       0  100.00%
contracts/0.4.24/utils/Pausable.sol                                9       0  100.00%
contracts/0.4.24/utils/Versioned.sol                               5       0  100.00%
contracts/0.6.12/WstETH.sol                                       17       0  100.00%
contracts/0.8.25/Accounting.sol                                   90       5  94.44%   117-120, 346, 372
contracts/0.8.25/interfaces/IDepositContract.sol                   0       0  100.00%
contracts/0.8.25/interfaces/ILido.sol                              0       0  100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol         0       0  100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol           0       0  100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                   0       0  100.00%
contracts/0.8.25/utils/AccessControlVoteable.sol                  29       0  100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                  3       0  100.00%
contracts/0.8.25/vaults/Dashboard.sol                             90       6  93.33%   473-489
contracts/0.8.25/vaults/Delegation.sol                            39       0  100.00%
contracts/0.8.25/vaults/Permissions.sol                           27       0  100.00%
contracts/0.8.25/vaults/StakingVault.sol                         101       0  100.00%
contracts/0.8.25/vaults/VaultFactory.sol                          32       0  100.00%
contracts/0.8.25/vaults/VaultHub.sol                             144     102  29.17%   111-124, 180-269, 284-350, 382-431, 443-451, 457-487, 501
contracts/0.8.25/vaults/interfaces/IStakingVault.sol               0       0  100.00%
contracts/0.8.4/WithdrawalsManagerProxy.sol                       61       0  100.00%
contracts/0.8.9/BeaconChainDepositor.sol                          21       2  90.48%   48, 51
contracts/0.8.9/Burner.sol                                        72       0  100.00%
contracts/0.8.9/DepositSecurityModule.sol                        128       0  100.00%
contracts/0.8.9/EIP712StETH.sol                                   16       0  100.00%
contracts/0.8.9/LidoExecutionLayerRewardsVault.sol                16       0  100.00%
contracts/0.8.9/LidoLocator.sol                                   20       0  100.00%
contracts/0.8.9/OracleDaemonConfig.sol                            28       0  100.00%
contracts/0.8.9/StakingRouter.sol                                316       0  100.00%
contracts/0.8.9/WithdrawalQueue.sol                               88       0  100.00%
contracts/0.8.9/WithdrawalQueueBase.sol                          146       0  100.00%
contracts/0.8.9/WithdrawalQueueERC721.sol                         89       0  100.00%
contracts/0.8.9/WithdrawalVault.sol                               21       0  100.00%
contracts/0.8.9/lib/Math.sol                                       4       0  100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                22      22  0.00%    88-172
contracts/0.8.9/lib/UnstructuredRefStorage.sol                     2       0  100.00%
contracts/0.8.9/oracle/AccountingOracle.sol                      190       2  98.95%   154-155
contracts/0.8.9/oracle/BaseOracle.sol                             89       1  98.88%   397
contracts/0.8.9/oracle/HashConsensus.sol                         263       1  99.62%   1005
contracts/0.8.9/oracle/ValidatorsExitBusOracle.sol                91      91  0.00%    96-461
contracts/0.8.9/proxy/OssifiableProxy.sol                         17       0  100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      218      56  74.31%   195, 232, 273-324, 413-441, 495-507, 558-561, 569, 578, 586, 697, 702-747, 802
contracts/0.8.9/utils/DummyEmptyContract.sol                       0       0  100.00%
contracts/0.8.9/utils/PausableUntil.sol                           31       0  100.00%
contracts/0.8.9/utils/Versioned.sol                               11       0  100.00%
contracts/0.8.9/utils/access/AccessControl.sol                    23       0  100.00%
contracts/0.8.9/utils/access/AccessControlEnumerable.sol           9       0  100.00%
contracts/common/utils/PausableUntil.sol                          29       1  96.55%   33
contracts/testnets/sepolia/SepoliaDepositAdapter.sol              21      21  0.00%    49-100
TOTAL                                                           3585     316  91.19%

Diff against master

Filename                                                       Stmts    Miss  Cover
-----------------------------------------------------------  -------  ------  --------
contracts/0.4.24/Lido.sol                                        -11      +6  -2.99%
contracts/0.4.24/StETH.sol                                        +7       0  +100.00%
contracts/0.8.25/Accounting.sol                                  +90      +5  +94.44%
contracts/0.8.25/interfaces/IDepositContract.sol                   0       0  +100.00%
contracts/0.8.25/interfaces/ILido.sol                              0       0  +100.00%
contracts/0.8.25/interfaces/IOracleReportSanityChecker.sol         0       0  +100.00%
contracts/0.8.25/interfaces/IPostTokenRebaseReceiver.sol           0       0  +100.00%
contracts/0.8.25/interfaces/IStakingRouter.sol                     0       0  +100.00%
contracts/0.8.25/interfaces/IWithdrawalQueue.sol                   0       0  +100.00%
contracts/0.8.25/utils/AccessControlVoteable.sol                 +29       0  +100.00%
contracts/0.8.25/utils/PausableUntilWithRoles.sol                 +3       0  +100.00%
contracts/0.8.25/vaults/Dashboard.sol                            +90      +6  +93.33%
contracts/0.8.25/vaults/Delegation.sol                           +39       0  +100.00%
contracts/0.8.25/vaults/Permissions.sol                          +27       0  +100.00%
contracts/0.8.25/vaults/StakingVault.sol                        +101       0  +100.00%
contracts/0.8.25/vaults/VaultFactory.sol                         +32       0  +100.00%
contracts/0.8.25/vaults/VaultHub.sol                            +144    +102  +29.17%
contracts/0.8.25/vaults/interfaces/IStakingVault.sol               0       0  +100.00%
contracts/0.8.9/Burner.sol                                        +1       0  +100.00%
contracts/0.8.9/LidoLocator.sol                                   +2       0  +100.00%
contracts/0.8.9/lib/PositiveTokenRebaseLimiter.sol                 0     +22  -100.00%
contracts/0.8.9/sanity_checks/OracleReportSanityChecker.sol      -14     +56  -25.69%
contracts/common/utils/PausableUntil.sol                         +29      +1  +96.55%
TOTAL                                                           +569    +198  -4.90%

Results for commit: e9a302d

Minimum allowed coverage is 90%

♻️ This comment has been updated with latest results

tamtamchik

Great start!

Some suggestions and comments left.

Also, looks like it need to me merged with vaults branch once again, because some tests are failing.

test/0.8.25/vaults/contracts/Protocol__Deployment.t.sol

test/0.8.25/vaults/contracts/ShareRate.t.sol

…-vebo-legacy-tests

fix: negative rebase tests on develop

feat: bunch of updates from develop to master

chore: migrate foundry to stable

feat: improve transactions logging

…cy-tests test: VEBO tests restored from legacy (val-1556)

This reverts commit e5aa190.

…-devnet

wip: local devnet

tamtamchik · 2025-02-19T13:14:55Z

Development moved to #952

eddort and others added 13 commits December 11, 2024 14:28

feat: initial deploy to local devnet

483b442

feat: speed up scratch deployment for local-devnet

e5aa190

refactor: add deployed-local-devnet.json to gitignore

ee55926

chore: add default pk for local devnet

ce8c268

feat: decrease voting time for devnet

2983d01

fix: consensusVersion in VEBO defaults

e879318

feat: update default params for devnet

ce1e448

feat: custom SLOTS_PER_EPOCH support

e622b3b

fix: change the module type on curated-onchain-v1 for SimpleDVT in th…

6c8bab8

…e scratch deploy

fix: vebo access control and deploy tests

cf98121

feat: vebo gas, submitReportData, happyPath tests

517076e

fix: submitReportData method tests

8fa4443

feat: test shareRate with fuzzing

afc5fa1

sergeyWh1te requested a review from tamtamchik January 10, 2025 14:42

tamtamchik reviewed Jan 13, 2025

View reviewed changes

tamtamchik and others added 5 commits January 13, 2025 15:27

Merge branch 'feat/vaults' into feat/vaults-fuzzing-share-rate

e772d2a

feat: test shareRate with fuzzing

0b6fc5c

feat: test shareRate with fuzzing

6317957

chore: some refactoring

c289fb8

feat: test shareRate with fuzzing

d79df96

tamtamchik added the vaults label Jan 14, 2025

Amuhar and others added 8 commits January 16, 2025 01:16

Merge remote-tracking branch 'origin/develop' into feat/val-1556-move…

3ac9843

…-vebo-legacy-tests

feat: fuzz oracleReport

167c387

chore: add oracle report related contracts

2386b48

fix: accounting initialization

79ecbbb

feat: added _sharesRequestedToBurn to fuzzing

7fc5b7f

feat: added _sharesRequestedToBurn to fuzzing

c9f78d0

feat: refactor fuzz.ProtocolDeployment

166ef4b

feat: fix incorrect timestamp for Report

c39aeea

tamtamchik and others added 28 commits February 11, 2025 11:33

fix: negative rebase

667791a

Merge pull request #943 from lidofinance/fix/develop

106c9c2

fix: negative rebase tests on develop

Merge pull request #942 from lidofinance/develop

9a5a20a

feat: bunch of updates from develop to master

feat: hardhat based logs

a4bd6b8

chore: cleanup logs

3155741

chore: refactor

d4a71e2

chore: migrate foundry to stable

986cfde

Merge pull request #946 from lidofinance/fix/foundry

b0c3352

chore: migrate foundry to stable

Merge pull request #944 from lidofinance/feat/auto-trace

2f28a18

feat: improve transactions logging

Merge branch 'develop' into feat/val-1556-move-vebo-legacy-tests

a8734c3

fix(test): vebo gas test

087b03e

test: speed up gas validation test

014df01

Merge pull request #917 from lidofinance/feat/val-1556-move-vebo-lega…

1ef6b88

…cy-tests test: VEBO tests restored from legacy (val-1556)

fix: hardhat config types

8ffcf2b

Revert "feat: speed up scratch deployment for local-devnet"

72a4628

This reverts commit e5aa190.

Merge branch 'develop' of github.com:lidofinance/core into feat/local…

965cd4c

…-devnet

fix: integration tests

6e7c60e

fix: IDepositContract format

d1fc7ec

refactor: reset defaults

f22a7a9

refactor: env vars

f4d128f

refactor: env example

9492d8f

fix: initialize WithdrawalVault

5e7e304

fix: hh etherscan config

b403164

fix: wv initialize

6089070

Merge pull request #896 from lidofinance/feat/local-devnet

25b4eda

wip: local devnet

feat: merge develop into fuzzShareRate

bec2685

feat: merge develop into fuzzShareRate

144188f

feat: merge develop into fuzzShareRate

9177a9e

tamtamchik closed this Feb 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: vaults fuzzing #918

test: vaults fuzzing #918

sergeyWh1te commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 •

edited

Loading

tamtamchik left a comment •

edited

Loading

tamtamchik commented Feb 19, 2025

test: vaults fuzzing #918

test: vaults fuzzing #918

Conversation

sergeyWh1te commented Jan 10, 2025

github-actions bot commented Jan 10, 2025 • edited Loading

Hardhat Unit Tests Coverage Summary

Diff against master

tamtamchik left a comment • edited Loading

Choose a reason for hiding this comment

tamtamchik commented Feb 19, 2025

github-actions bot commented Jan 10, 2025 •

edited

Loading

tamtamchik left a comment •

edited

Loading