Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design feedback update #106

Merged
merged 14 commits into from
Mar 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Copy link
Member

@Shiun Shiun Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contenders in this context == candidates? It seems like these two terms are interchanged in the pngs.

Maybe clarification isn't necessary since this is just an example of the structure of the speclet, not the content itself.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
3 changes: 2 additions & 1 deletion index.md
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ Feel free to explore, and if anything catches your attention or raises questions
- [Design Principles](product_design/design_principles.md)
- [Design Review Best Practices](product_design/design-review-best-practices.md)
- [Giving and Receiving Feedback](product_design/giving-and-receiving-design-feedback.md)
- [How to Write User Stories](/product_design/how_we_write_user_stories.md)
- [Epics and User Stories](/product_design/how_we_write_user_stories.md)
- [Structuring Epics, Stories, Bugs and Tasks(product_design/structuring_epics_stories_bugs_and_tasks.md)
- [Accessibility](product_design/accessibility_guide.md)


Expand Down
5 changes: 4 additions & 1 deletion product_design/design-review-best-practices.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Design Review Best Practices

* Contents
{:toc}

### The goal of design reviews
Design is an iterative and collaborative process. It takes many conversations to get from an initial idea to a complete product. Early conversations may be about getting alignment on the problem space. Other conversations may be about getting sign off to start building the design in code. For the purposes of this guide, we are looking at conversations we'll call "design reviews."
Design is an iterative and collaborative process. It takes many conversations to get from an initial idea to a complete product. Early conversations may be about getting alignment on the problem space. Other conversations may be about getting sign off to start building the design in code. For the purposes of this guide, we are looking at conversations meant to get feedback on work in progress. We'll call these conversations "design reviews."

Design reviews give us an opportunity to step back and look at the work critically. This type of conversation helps us ensure our designs are on track. A design review has two goals. First, we must understand the design in context. Next, we give feedback to improve the design so it best meets our business objectives and the needs of our users.

Expand Down
19 changes: 14 additions & 5 deletions product_design/giving-and-receiving-design-feedback.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# Giving and receiving design feedback effectively takes practice
It’s not always easy to give and receive design feedback. A negative past experience might make a designer hesitant to ask for or participate in a review. Unfortunately, we can’t produce good work without getting or giving feedback.

It’s not always easy to give and receive design feedback. A negative past experience or feeling uncertain about what to say might make us hesitant to ask for or participate in a review. Unfortunately, we can’t produce good work without getting or giving feedback.

Practicing giving and receiving feedback will help us grow as a team. This guide provides an overview of behaviors to strive for in a design review. We don't have to get them right each time, but making an effort counts.

* Contents
{:toc}

## Best practices for giving feedback
The goal of giving feedback is to help evaluate a design in terms of how well the design meets its objectives. As feedback givers, we have a duty to our teammates to be thoughtful. There are several ways we can give thoughtful feedback:
The goal of giving feedback is to help evaluate a design in terms of how well the design meets its objectives. We want to lift the idea up and make it stronger, not tear it down. As feedback givers, we have a duty to our teammates to be thoughtful. There are several ways we can give thoughtful feedback:

### Lead with questions
Asking questions about the design helps us give informed feedback. It shows the designer you’re interested in both their work and their reasoning behind it. Delivering feedback on an incorrect assumption could take the conversation off track. Asking questions helps you determine if your assumption is accurate. The resulting feedback is more likely to be relevant to the objectives.
Expand All @@ -31,7 +35,7 @@ It may seem odd to go through the process of identifying problems with a design

One exception to this guideline: when a designer asks for this type of help. It's okay to brainstorm solutions if both parties have agreed to have this type of conversation. If you're not sure if a designer is asking for this type of help, ask.


---

## Best practices for receiving feedback
When asking for feedback, we are taking a step back from the generative phase to look critically at our work and how well it meets our design goals. As feedback receivers, our duty is to listen and remember that critique is about improving the design, not a judgment of us as individuals. There are several ways we can engage as feedback recipients:
Expand All @@ -48,18 +52,23 @@ If this is a follow-up critique and the reviewer contradicts their earlier feedb

If you’re struggling to both listen and take notes, consider having someone take notes for you. Another option is to take notes on a whiteboard or in a document visible to the team. This visibility will also help you and the team be sure you’re on the same page.

If you want praise, don’t hesitate to ask: “What about this design is working well?” Don’t expect a design review itself to be a source of praise.
### It's okay to ask for praise
If you want praise, don’t hesitate to ask: “What about this design is working well?”
Don’t expect a design review itself to be a source of praise.


### Participate
You’re allowed to critique your work, too. Try picking one of the personas and imagining what this design might be like for them. Are they able to meet their goals? This activity helps you practice critiquing skills and strengthens your ability to switch between the creative mindset and the analytical mindset. It can put the other reviewers at ease to see you talk openly about your own work.

### Stay on target
If you feel like your discussion is getting off topic or you’re getting feedback that seems out of left field, refer to the context you set in the beginning. Is everyone on the same page? If they aren’t, we either need more alignment, or we may need to reevaluate our foundation.

If you find your discussions frequently get off topic, review our guide, [Design Review Best Practices](../product_design/design-review-best-practices.md), for tips on how to structure the converstation for best results.



---
**Sources**
#### Sources

[Adam Connor and Aaron Irizarry, *Discussing Design* (O’Reilly, 2015.)](http://www.discussingdesign.com/)
Available in handy cheat-sheet form: [http://www.discussingdesign.com/downloads/Critique_CheatSheet.pdf](http://www.discussingdesign.com/downloads/Critique_CheatSheet.pdf)
Expand Down
Loading
Loading