Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design feedback update #106

Merged
merged 14 commits into from
Mar 11, 2024
Merged

Design feedback update #106

merged 14 commits into from
Mar 11, 2024

Conversation

traceykthompson
Copy link
Contributor

Updated The Design Review Best Practices and Giving + Receiving feedback guides.
Added a TOC to each and small content changes for clarity.
Also added a cross-link from G+R Feedback to Design Review

Added a TOC 
Added additional content to clarify goals.
Added a TOC
Added clarification that Design Reviews are an opportunity to get feedback.
Cross-posted to design review guide.
Added new page on ticket structure, updated title for writing user stories.
Added new page for ticket specifics
Added images from confluence for structuring tickets
deleting so I can re-add with dash in the title
adding links to the structure guide
Removed Steve Bockman article. It's a 404. and I can't find a replacement article to link to.
@traceykthompson traceykthompson requested a review from Shiun March 11, 2024 21:00

## What is needed before we write user stories?
- Epics describe the vision and the outcomes we are striving to achieve and how we intend to measure success.
- User stories generate empathy and alignment around a discrete effort and how that work will benefit the user. Writing user stories helps us come to an agreement on what needs to be done and what criteria we will use to tell when the work is complete.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that Epics are composed of a set of stories? Epics are high level visions or large slices of functionality? And stories are individual discrete pieces of work in the epic? (need better word smithing here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katebennet would you be able to address @Shiun's content questions?

Copy link
Member

@Shiun Shiun Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Contenders in this context == candidates? It seems like these two terms are interchanged in the pngs.

Maybe clarification isn't necessary since this is just an example of the structure of the speclet, not the content itself.

Initiatives are a collection of epics that drive towards a common goal (for example: “expand in to Australia” or “launch a new product that decreases costs by 7% this year”). An initiative is broader than a single epic, and may span multiple teams and multiple quarters.

## Epics
Epics convey the overall big picture priorities. They contain a group of stories (on a particular theme) that are too big to be described by a single user story. Epics are written concisely and in a way that is simple to understand.
Copy link
Member

@Shiun Shiun Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"They contain a group of stories (on a particular theme) that are too big to be described by a single user story. Epics are written concisely and in a way that is simple to understand."

OK it looks like we mention it here. (re: Epics = group of stories) Maybe same reiteration can be placed to my earlier comment above? (https://github.com/labzero/guides/pull/106/files#r1520446023)

Copy link
Member

@Shiun Shiun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. The content of the speclet png probably don't need to be address since it's not relevant to the guide. Especially since the example speclets are referenced for their structure, not content.

Maybe a re-interation of Epics being composed of stories would be a good edition in the definition of Epics/Stories.

Otherwise, looks great!

@traceykthompson traceykthompson merged commit 31140a6 into master Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants