Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-use binary of build stage in docker image #27

Merged
merged 7 commits into from
Mar 21, 2025

Conversation

jandelgado
Copy link
Owner

@jandelgado jandelgado commented Mar 16, 2025

  • simplify dockerfile
  • use go version from toolchain definition in go.mod
  • show linter findings in MR

@coveralls
Copy link

coveralls commented Mar 16, 2025

Coverage Status

coverage: 50.0%. remained the same
when pulling 2968db3 on build_artefacts_only_once
into 51383b0 on master.

@jandelgado jandelgado changed the title re-use build binary in docker image DRAFT: re-use build binary in docker image Mar 18, 2025
@jandelgado jandelgado changed the title DRAFT: re-use build binary in docker image re-use build binary in docker image Mar 19, 2025
@jandelgado jandelgado force-pushed the build_artefacts_only_once branch from 9c0dcd2 to c286e90 Compare March 19, 2025 21:17
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

}

func main() {
Hello()
}
Hello() // return value intentionally not checked to trigger linter

Check failure

Code scanning / golangci-lint

Error return value is not checked Error

Error return value is not checked
@jandelgado jandelgado changed the title re-use build binary in docker image re-use binary of build stage in docker image Mar 21, 2025
@jandelgado jandelgado force-pushed the build_artefacts_only_once branch from 2968db3 to 2327110 Compare March 21, 2025 19:32
@jandelgado jandelgado force-pushed the build_artefacts_only_once branch from a79f1cb to 49283cb Compare March 21, 2025 19:41
@jandelgado jandelgado merged commit d88e435 into master Mar 21, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants