VARCHAR support #227
Merged
VARCHAR support #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillAyd
commented
Jan 18, 2024
| ("unimplemented pandas dtype for type: " + sqltype.toString()).c_str()); | ||
| static auto arrowTypeFromHyper(const hyperapi::SqlType &sqltype) | ||
| -> enum ArrowType { | ||
| switch (sqltype.getTag()){ |
There was a problem hiding this comment.
Hmm this formatting from clang-format is terribly hard to read...wonder what is going on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reimplementation of #211 in the new 4.0 model. Had to change the test around as previously it relied on a dtype mapper that no longer exists