Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pythonless read #226

Merged
merged 6 commits into from
Jan 18, 2024
Merged

Pythonless read #226

merged 6 commits into from
Jan 18, 2024

Conversation

WillAyd
Copy link
Collaborator

@WillAyd WillAyd commented Jan 18, 2024

No description provided.

@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 18, 2024

First benchmark run:

| Change   | Before [5cfcf2b9] <main>   | After [a31f76ae] <pythonless-read>   |   Ratio | Benchmark (Parameter)                      |
|----------|----------------------------|--------------------------------------|---------|--------------------------------------------|
| -        | 98.1±5ms                   | 67.9±4ms                             |    0.69 | benchmarks.TimeSuite.time_read_frame       |
| -        | 2.95±0.05s                 | 382±50ms                             |    0.13 | benchmarks.TimeReadLong.time_read_frame    |
| -        | 2.16G                      | 253M                                 |    0.12 | benchmarks.TimeReadLong.peakmem_read_frame |

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 18, 2024

Benchmarks compared to 3.0.3 (there was some regression in reading with the initial move to nanoarrow):

| Change   | Before [1f067879] <3.0.3~7>   | After [a31f76ae] <pythonless-read>   |   Ratio | Benchmark (Parameter)                      |
|----------|-------------------------------|--------------------------------------|---------|--------------------------------------------|
| -        | 98.2±4ms                      | 68.5±2ms                             |    0.7  | benchmarks.TimeSuite.time_read_frame       |
| -        | 1.63±0.07s                    | 393±20ms                             |    0.24 | benchmarks.TimeReadLong.time_read_frame    |
| -        | 1.28G                         | 254M                                 |    0.2  | benchmarks.TimeReadLong.peakmem_read_frame |

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE INCREASED.

@WillAyd WillAyd merged commit 48f6541 into main Jan 18, 2024
4 checks passed
@WillAyd WillAyd deleted the pythonless-read branch January 18, 2024 22:48
@WillAyd WillAyd added this to the 4.0 milestone Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant