Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.X reader regressions #221

Closed
WillAyd opened this issue Jan 14, 2024 · 2 comments
Closed

4.X reader regressions #221

WillAyd opened this issue Jan 14, 2024 · 2 comments

Comments

@WillAyd
Copy link
Collaborator

WillAyd commented Jan 14, 2024 •
edited
Loading

ASV benchmarks show the reader taking more time and peak memory usage in pantab 4.X. Needs further investigation
@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 14, 2024

Change Before [1f06787] <3.0.3~7> After [6059ad7] Ratio Benchmark (Parameter)
+ 1.40±0.04s 3.17±0.03s 2.27 benchmarks.TimeReadLong.time_read_frame
+ 1.28G 2.16G 1.69 benchmarks.TimeReadLong.peakmem_read_frame

SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE DECREASED.

@WillAyd WillAyd changed the title 4.X reader memory regression 4.X reader regressions Jan 14, 2024
@WillAyd
Copy link
Collaborator Author

WillAyd commented Jan 19, 2024

closed in #226

@WillAyd WillAyd closed this as completed Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WillAyd