-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update handling of duplicate batches to avoid editing existing messages #1647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
10 tasks
awrichar
reviewed
Feb 28, 2025
awrichar
reviewed
Feb 28, 2025
awrichar
reviewed
Feb 28, 2025
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Good find; thanks for fixing this. |
awrichar
previously approved these changes
Feb 28, 2025
Signed-off-by: Peter Broadhurst <peter.broadhurst@kaleido.io>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1647 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 337 337
Lines 29607 29632 +25
=======================================
+ Hits 29595 29620 +25
Misses 8 8
Partials 4 4 ☔ View full report in Codecov by Sentry. |
awrichar
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
If a FireFly node receives a batch a 2nd time, you can end up with messages that are:
pending
(without aconfirmed
time)message_confirmed
event associatedLogically this should be impossible, but it happens because we overwrite the message
state
in the upsert logic, after the insert fails.Easy to recreate this, by just using
/operation/{opId}/retry
to re-send a batch containing confirmed messages.This PR changes the fallback logic, after the insert fails, to only insert the missing messages.
Types of changes
< issue name >
egAdded links in the documentation
.