Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[privatemessaging] [operations] Ensure Transports are Networked for Retried Messages #1648

Merged

Conversation

onelapahead
Copy link
Contributor

Proposed changes

Fixes a bug when retrying sending a private message (dataexchange_send) operation, that the transport wrapper's batch uses the local namespace rather than the network namespace (i.e. the globally unique name for the network) unlike what is done when the message is initially sent.

If the receiver's local namespace does not match the network namespace, it drops the messages as result because it cannot map the namespace + recipient to its local node.

Types of changes

  • Bug fix
  • New feature added
  • Documentation Update

Please make sure to follow these points

  • I have read the contributing guidelines.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • My Pull Request title is in format < issue name > eg Added links in the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • My changes have sufficient code coverage (unit, integration, e2e tests).

Screenshots (If Applicable)


Other Information

We observed when retrying message operations (related to #1647) that a node might log the following when dropping the received, retried messages:

[2025-02-27T16:11:56.626Z] ERROR Unknown local node for DX event 'ea7e6009-40fd-4016-ab61-32cce63ec6ae' recipient=org1/org1-org1-firefly dx=https pid=1

…etried Messages

Signed-off-by: hfuss <hayden.fuss@kaleido.io>
@onelapahead onelapahead requested a review from a team as a code owner February 28, 2025 04:29
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Must have been a gnarly one to work out.

Linter called out some 2024 headers to update.

Signed-off-by: hfuss <hayden.fuss@kaleido.io>
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (551e1af) to head (0569b53).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         337      337           
  Lines       29593    29607   +14     
=======================================
+ Hits        29581    29595   +14     
  Misses          8        8           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterbroadhurst peterbroadhurst merged commit 490539e into hyperledger:main Feb 28, 2025
19 checks passed
@peterbroadhurst peterbroadhurst deleted the fix-transportwrapper-networkname branch February 28, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants