add sdpa for phi3 openvino model #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@echarlaix @AlexKoff88 could you please take a look? |
AlexKoff88
approved these changes
May 14, 2024
echarlaix
approved these changes
May 14, 2024
| use_cache=use_cache, | ||
| ) | ||
|
|
||
| from transformers.models.llama.modeling_llama import apply_rotary_pos_emb, repeat_kv |
There was a problem hiding this comment.
even if currently equivalent shouldn't be replace it with
Suggested change
| from transformers.models.llama.modeling_llama import apply_rotary_pos_emb, repeat_kv | |
| from transformers.models.phi3.modeling_phi3 import apply_rotary_pos_emb, repeat_kv |
to avoid any issue resulting from potential refactorization
There was a problem hiding this comment.
I believe it will breaks with current release, because phi3 code in transformers is not released yet on pypi... Can we add some TODO to change this in future (currently model is loaded using trust_remote_code using stable transformers release)?
There was a problem hiding this comment.
yes works for me, thanks @eaidova !
Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
… into ea/phi3_sdpa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting