Merge 8 -> main #2378
Merged
Merge 8 -> main #2378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: retinfai <aferetipama@gmail.com>
…ata (#2358) Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
# Summary The examples/worlds directory does not contain any example world for DopplerVelocityLogSystem plugin. This PR adds the following: Example world based on test/worlds/flat_seabed.sdf but with a SceneBroadcaster. README.md in test/worlds directory to inform users not to use those world files. More information can be found in Issue #2344 and PR #2346. # Test it This world can be tested (after building and sourcing the workspace) using the following command ``` gz sim flat_seabed.sdf ``` --------- Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
* Do not need distutils on jammy Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> --------- Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
--------- Signed-off-by: Ian Chen <ichen@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
arjo129
approved these changes
May 2, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2378 +/- ##
==========================================
+ Coverage 65.66% 65.95% +0.28%
==========================================
Files 324 327 +3
Lines 30938 31319 +381
==========================================
+ Hits 20315 20655 +340
- Misses 10623 10664 +41 ☔ View full report in Codecov by Sentry. |
azeey
approved these changes
May 2, 2024
|
I think the warning on Jammy is an existing issue and should be fixed in a follow up PR. This is good to merge. |
mjcarroll
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port gz-sim8 to main
Branch comparison: main...gz-sim8
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)