Fix GridConfig pose updates #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this fix, if the value property has a binding instead of a value, any modification from the GUI (e.g. hitting the up arrow on the spin box) would not actually change the displayed value because it is immediately reset back to the value set by the binding. This is the case in the `GzPose` module and the effect can be easily be seen in the `GridConfig` plugin. To test, run: `gz gui -c examples/config/grid_config.config` You will see that, before this change, modifying the x,y,z,roll,pitch, yaw values actually changes the grid configuration, but the updated values are not displayed in the spinbox. Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Ian Chen <ichen@openrobotics.org>
8 tasks
Signed-off-by: Ian Chen <ichen@openrobotics.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #658 +/- ##
==========================================
- Coverage 68.70% 68.67% -0.04%
==========================================
Files 38 38
Lines 5532 5548 +16
==========================================
+ Hits 3801 3810 +9
- Misses 1731 1738 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
caguero
approved these changes
Mar 12, 2025
ticketed an issue for this. #660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
Follow up to #656. This PR fixes pose updates the GridConfig plugin.
Previously if you click on one of the GzPose spinboxes, e.g.
x, followed by clicking on another spinbox, e.g.y, the first pose component (x) gets reset to the initial value. It was found that it was because the GzPose instance (gzPoseInstance) properties were incorrectly bound to the initial pose values (passed in byonNewParamsin QML). This PR adds a newgridPoseproperty for handling read/writes from C++ and QML.Before:
After:
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.