Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GzSpinBox in cases where the value property has a binding #656

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Feb 26, 2025

🦟 Bug fix

Summary

Before this fix, if the value property has a binding instead of a value,
any modification from the GUI (e.g. hitting the up arrow on the spin
box) would not actually change the displayed value because it is
immediately reset back to the value set by the binding. This is the case
in the GzPose module and the effect can be easily be seen in the
GridConfig plugin. To test, run:

gz gui -c examples/config/grid_config.config

You will see that, before this change, modifying the x,y,z,roll,pitch,
yaw values actually changes the grid configuration, but the updated values are
not displayed in the spinbox.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Before this fix, if the value property has a binding instead of a value,
any modification from the GUI (e.g. hitting the up arrow on the spin
box) would not actually change the displayed value because it is
immediately reset back to the value set by the binding. This is the case
in the `GzPose` module and the effect can be easily be seen in the
`GridConfig` plugin. To test, run:

`gz gui -c examples/config/grid_config.config`

You will see that, before this change, modifying the x,y,z,roll,pitch,
yaw values actually changes the grid configuration, but the updated values are
not displayed in the spinbox.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@azeey azeey requested a review from jennuine as a code owner February 26, 2025 20:16
@github-actions github-actions bot added the 🪵 jetty Gazebo Jetty label Feb 26, 2025
@azeey azeey mentioned this pull request Feb 26, 2025
13 tasks
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. While testing, I ran into another issue with setting grid pose in GridConfig plugin. I'll create a separate PR for this.

@iche033 iche033 merged commit 4ca0db0 into gazebosim:main Mar 6, 2025
11 checks passed
@iche033 iche033 mentioned this pull request Mar 6, 2025
8 tasks
@iche033
Copy link
Contributor

iche033 commented Mar 6, 2025

This works for me. While testing, I ran into another issue with setting grid pose in GridConfig plugin. I'll create a separate PR for this.

#658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪵 jetty Gazebo Jetty
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants