Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(cmake): Make monolithic libs be built inside Velox's own binary directory when being used as a subproject #12144

Closed
wants to merge 1 commit into from
Closed

build(cmake): Make monolithic libs be built inside Velox's own binary directory when being used as a subproject #12144

wants to merge 1 commit into from

Conversation

zhztheplayer
Copy link
Contributor

Similar to #12128, currently when Velox is imported as a subproject of another project, the monolithic libs libvelox.a / libvelox.so will be generated in root project's binary directory which is sub-optimal.

The patch fixes the issue so the libs will be generated inside Velox's binary directory.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 22, 2025 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 7eecf69
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/679610ff3a2cb4000811ee42

@zhztheplayer
Copy link
Contributor Author

cc @assignUser thank you

@assignUser assignUser added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 24, 2025
@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zhztheplayer
Copy link
Contributor Author

Hi @assignUser @xiaoxmeng

CI is red and I can't see the reason. Any suggestions? Thanks!

@assignUser
Copy link
Collaborator

The issue is unrelated, pyvelox currently fails to build #12185

@zhztheplayer
Copy link
Contributor Author

The issue is unrelated, pyvelox currently fails to build #12185

@assignUser Thanks. I mean the other job from my previous commit was failing, the job name was Facebook GitHub Tools / Facebook Internal - Builds & Tests.

@assignUser
Copy link
Collaborator

Ah as the name says that's a meta internal job, if it's something you have to address the meta employee landing the pr will let you know.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@xiaoxmeng merged this pull request in 9fd0b0f.

@conbench-facebook conbench-facebook
Copy link

Conbench analyzed the 1 benchmark run on commit 9fd0b0f3.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgpai kgpai kgpai approved these changes

@assignUser assignUser assignUser approved these changes

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhztheplayer @facebook-github-bot @assignUser @kgpai