Skip to content

Commit 9fd0b0f

Browse files
zhztheplayerfacebook-github-bot
authored andcommitted
build(cmake): Make monolithic libs be built inside Velox's own binary directory when being used as a subproject (#12144)
Summary: Similar to #12128, currently when Velox is imported as a subproject of another project, the monolithic libs `libvelox.a` / `libvelox.so` will be generated in root project's binary directory which is sub-optimal. The patch fixes the issue so the libs will be generated inside Velox's binary directory. Pull Request resolved: #12144 Reviewed By: kgpai Differential Revision: D68606631 Pulled By: xiaoxmeng fbshipit-source-id: d0ef042c5ee935a598637b07549c9c48a06708fe
1 parent 1692f5b commit 9fd0b0f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

CMake/VeloxUtils.cmake

+2-2
Original file line numberDiff line numberDiff line change
@@ -77,9 +77,9 @@ function(velox_add_library TARGET)
7777
# Create the target if this is the first invocation.
7878
add_library(velox ${_type} ${ARGN})
7979
set_target_properties(velox PROPERTIES LIBRARY_OUTPUT_DIRECTORY
80-
${CMAKE_BINARY_DIR}/lib)
80+
${PROJECT_BINARY_DIR}/lib)
8181
set_target_properties(velox PROPERTIES ARCHIVE_OUTPUT_DIRECTORY
82-
${CMAKE_BINARY_DIR}/lib)
82+
${PROJECT_BINARY_DIR}/lib)
8383
install(TARGETS velox DESTINATION lib/velox)
8484
endif()
8585
# create alias for compatability

0 commit comments

Comments
 (0)