Add affixations to buffer switching functions when exordium-help-extensions #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `after` uses `eval-after-load` unconditionally, which, in case of setting up bindings is an overkill, as all bindings are in global map
Add a new keybinding for Google suggest and remap `switch-to-buffer` to `helm-buffers-list`, which offers a couple alternative actions on buffers. Also turn on detailed completions.
`helm-xref` unconditionally hijacks `xref-show-xrefs-function` and `xref-show-definitions-function`. I don't think this is expected. BREAKING CHANGE: don't install `helm-xref` unless in `exordium-helm-everywhere`
Need to use generic `completing-read` framework to get affixation to work. The latter however doesn't have any actions defined, so copying relevant attributes from `helm-source-buffers-list`. BREAKING CHANGE: When `exordium-helm-everywhere` the binding `C-x b` now points to `switch-to-buffer` (was: `helm-buffers-list`). This is consistent with other bindings (for example `C-x 4 b` - `switch-to-buffer-other-window`), but some extra behaviour from `helm-buffers-list` is not available (i.e., candidate buffers sorting and highlighting).
This is done in an attempt to provide a consistent interface when switching to a buffer, and is hidden behind `exordium-extra-help` flag. This is done similarily to what Exordium does for `switch-to-buffer` and `helpful` commands do under the hood. Both of these, when `completions-detailed` is non-nil use `helm-completing-read-extra-metadata` to select an affixation function.
pkryger
requested review from
philippe-grenet and
steve-downey
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures consistency when switching to buffers using different methods, for
example
swich-to-buffer, C-x b,swich-to-buffer-other-window,C-x 4 b, or
projectile-switch-to-buffer, C-c p b.Using the opportunity to add a few minor fixes, and a couple of new keybindings.
As usual, please see individual commits for details.