disable admin routes entirely if config not set

devict · Feb 23, 2025 · da8537c · da8537c
1 parent 00f30f9
commit da8537c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -16,8 +16,8 @@ type Config struct {
 	Email         *EmailConfig
 	Twitter       *TwitterConfig
 	SlackHook     string `envconfig:"SLACK_HOOK"`
-	AdminUser     string `envconfig:"ADMIN_USER" required:"true" default:"admin"`
-	AdminPassword string `envconfig:"ADMIN_PASSWORD" require:"true" default:"password"`
+	AdminUser     string `envconfig:"ADMIN_USER"`
+	AdminPassword string `envconfig:"ADMIN_PASSWORD"`
 }
 
 type EmailConfig struct {

diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -80,16 +80,18 @@ func NewServer(c *ServerConfig) (http.Server, error) {
 		authorized.POST("/jobs/:id/delete", ctrl.DeleteJob)
 	}
 
-	// Admin routes
-	admin := router.Group("/admin")
-	admin.Use(gin.BasicAuth(gin.Accounts{
-		c.Config.AdminUser: c.Config.AdminPassword,
-	}))
-	{
-		admin.GET("", ctrl.AdminIndex)
-		admin.GET("/jobs/:id/edit", ctrl.EditJob)
-		admin.POST("/jobs/:id", ctrl.UpdateJob)
-		admin.POST("/jobs/:id/delete", ctrl.DeleteJob)
+	if c.Config.AdminUser != "" {
+		// Admin routes
+		admin := router.Group("/admin")
+		admin.Use(gin.BasicAuth(gin.Accounts{
+			c.Config.AdminUser: c.Config.AdminPassword,
+		}))
+		{
+			admin.GET("", ctrl.AdminIndex)
+			admin.GET("/jobs/:id/edit", ctrl.EditJob)
+			admin.POST("/jobs/:id", ctrl.UpdateJob)
+			admin.POST("/jobs/:id/delete", ctrl.DeleteJob)
+		}
 	}
 
 	return http.Server{