set defaults on the config object

devict · Feb 23, 2025 · 00f30f9 · 00f30f9
1 parent 8ed57a0
commit 00f30f9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/pkg/config/config.go b/pkg/config/config.go
@@ -16,8 +16,8 @@ type Config struct {
 	Email         *EmailConfig
 	Twitter       *TwitterConfig
 	SlackHook     string `envconfig:"SLACK_HOOK"`
-	AdminUser     string `envconfig:"ADMIN_USER"`
-	AdminPassword string `envconfig:"ADMIN_PASSWORD"`
+	AdminUser     string `envconfig:"ADMIN_USER" required:"true" default:"admin"`
+	AdminPassword string `envconfig:"ADMIN_PASSWORD" require:"true" default:"password"`
 }
 
 type EmailConfig struct {

diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -82,13 +82,9 @@ func NewServer(c *ServerConfig) (http.Server, error) {
 
 	// Admin routes
 	admin := router.Group("/admin")
-
-	accounts := gin.Accounts{}
-	if c.Config.AdminUser != "" {
-		accounts[c.Config.AdminUser] = c.Config.AdminPassword
-	}
-
-	admin.Use(gin.BasicAuth(accounts))
+	admin.Use(gin.BasicAuth(gin.Accounts{
+		c.Config.AdminUser: c.Config.AdminPassword,
+	}))
 	{
 		admin.GET("", ctrl.AdminIndex)
 		admin.GET("/jobs/:id/edit", ctrl.EditJob)