Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Poetry v2 #11642

Merged
merged 27 commits into from
Mar 3, 2025
Merged

Use Poetry v2 #11642

merged 27 commits into from
Mar 3, 2025

Conversation

edgarrmondragon
Copy link
Contributor

@edgarrmondragon edgarrmondragon commented Feb 19, 2025

What are you trying to accomplish?

Run Dependabot updates for Poetry projects using Poetry v2.

Anything you want to highlight for special attention from reviewers?

Poetry now fails instead of only warning when the lockfile is outdated and the project cannot be installed, so I had to update a few fixtures.

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

Related

@eggplants
Copy link
Contributor

Deprecated poetry.dev-dependencies sections in some pyproject.toml files have to be replaced with poetry.group.dev.dependencies.
python-poetry/poetry-core#754

@edgarrmondragon
Copy link
Contributor Author

Deprecated poetry.dev-dependencies sections in some pyproject.toml files have to be replaced with poetry.group.dev.dependencies. python-poetry/poetry-core#754

They're deprecated but I don't think they'll be removed any time soon, so I'll consider them out-of-scope for bumping to Poetry v2. Unless a maintainer has a different opinion.

@eggplants
Copy link
Contributor

eggplants commented Feb 19, 2025

3 tests are failing due to use of poetry.dev-dependencies
https://github.com/dependabot/dependabot-core/actions/runs/13424227136/job/37503789398?pr=11642

@edgarrmondragon
Copy link
Contributor Author

3 tests are failing due to use of poetry.dev-dependencies

I think it's rather

The lock file is not compatible with the current version of Poetry.
Regenerate the lock file with the `poetry lock` command.

that's causing the failures.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review February 21, 2025 01:37
@edgarrmondragon edgarrmondragon requested a review from a team as a code owner February 21, 2025 01:37
@edgarrmondragon

This comment was marked as outdated.

@eggplants
Copy link
Contributor

Hard to merge? I think all failed smoke tests related to updating Poetry V2 were passed.

@edgarrmondragon

This comment was marked as off-topic.

@thavaahariharangit thavaahariharangit self-assigned this Feb 28, 2025
@sergeyklay
Copy link

@randhircs @markhallen @thavaahariharangit @kbukum1

Hey folks,

Would you mind taking a look at this pull request when you get a chance? Many of us have been waiting for these changes for months, and for some, dependabot has been completely broken during this time due to version incompatibility issues with poetry.

It would mean a lot to us if you could review and help get a release out with these fixes. Thanks in advance!

@eggplants

This comment was marked as resolved.

@thavaahariharangit thavaahariharangit merged commit 18efef7 into dependabot:main Mar 3, 2025
46 of 47 checks passed
@edgarrmondragon edgarrmondragon deleted the poetry-2 branch March 3, 2025 20:29
github-merge-queue bot pushed a commit to meltano/meltano that referenced this pull request Mar 4, 2025
<!--

Please, go through these steps when you submit a PR.

1. Make sure your branch is not protected. In particular, avoid making
PRs from the `main` branch of your fork.

2. Give a descriptive title to your PR. We use semantic titles, and the
accepted types and scopes are listed in
https://github.com/meltano/meltano/blob/main/.github/semantic.yml.

   A good title should look like this:

   ```
feat(cli): The `meltano run` command now accepts a `--timeout` option to
limit the time it runs
   ```

3. Provide a description of your changes.

4. Put "Closes #XXXX" in your comment to auto-close the issue that your
PR fixes (if such).

-->

## Description

<!-- Describe the changes introduced by this PR -->

Blockers:

- dependabot/dependabot-core#11638
- dependabot/dependabot-core#11642
- python-poetry/poetry#9943

## Related Issues

* #9014
@sergeyklay
Copy link

@thavaahariharangit Just got slammed with tons Dependabot PRs after months of ignoring updates due to Poetry 2.x. My repo’s basically a fireworks show now haha. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants