-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Poetry v2 #11642
Use Poetry v2 #11642
Conversation
40fb6dd
to
ddcb164
Compare
Deprecated |
They're deprecated but I don't think they'll be removed any time soon, so I'll consider them out-of-scope for bumping to Poetry v2. Unless a maintainer has a different opinion. |
3 tests are failing due to use of |
I think it's rather
that's causing the failures. |
635518b
to
d417437
Compare
This comment was marked as outdated.
This comment was marked as outdated.
5dfc45b
to
7385d35
Compare
Hard to merge? I think all failed smoke tests related to updating Poetry V2 were passed. |
This comment was marked as off-topic.
This comment was marked as off-topic.
@randhircs @markhallen @thavaahariharangit @kbukum1 Hey folks, Would you mind taking a look at this pull request when you get a chance? Many of us have been waiting for these changes for months, and for some, dependabot has been completely broken during this time due to version incompatibility issues with poetry. It would mean a lot to us if you could review and help get a release out with these fixes. Thanks in advance! |
This reverts commit 35683de.
This comment was marked as resolved.
This comment was marked as resolved.
<!-- Please, go through these steps when you submit a PR. 1. Make sure your branch is not protected. In particular, avoid making PRs from the `main` branch of your fork. 2. Give a descriptive title to your PR. We use semantic titles, and the accepted types and scopes are listed in https://github.com/meltano/meltano/blob/main/.github/semantic.yml. A good title should look like this: ``` feat(cli): The `meltano run` command now accepts a `--timeout` option to limit the time it runs ``` 3. Provide a description of your changes. 4. Put "Closes #XXXX" in your comment to auto-close the issue that your PR fixes (if such). --> ## Description <!-- Describe the changes introduced by this PR --> Blockers: - dependabot/dependabot-core#11638 - dependabot/dependabot-core#11642 - python-poetry/poetry#9943 ## Related Issues * #9014
@thavaahariharangit Just got slammed with tons Dependabot PRs after months of ignoring updates due to Poetry 2.x. My repo’s basically a fireworks show now haha. Thanks! |
What are you trying to accomplish?
Run Dependabot updates for Poetry projects using Poetry v2.
Anything you want to highlight for special attention from reviewers?
Poetry now fails instead of only warning when the lockfile is outdated and the project cannot be installed, so I had to update a few fixtures.
How will you know you've accomplished your goal?
Checklist
Related