Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRSQC WDL First Iteration #177

Merged
merged 16 commits into from
Jun 11, 2024
Merged

PRSQC WDL First Iteration #177

merged 16 commits into from
Jun 11, 2024

Conversation

kockan
Copy link
Contributor

@kockan kockan commented Jun 6, 2024

  • Satisfies basic requirements (prs_score and full_model_score thresholds/boundaries)
  • Allows manual passing of controls
  • Nice visual PCA QC output(s) which can be easily displayed on the google bucket page
  • Input file format(s)/header(s)/etc. subject to change in future iterations

@kockan kockan requested a review from kachulis June 6, 2024 14:15
kachulis
kachulis requested changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@kachulis kachulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kockan! A few restructuring comments.

@kockan
Copy link
Contributor Author

kockan commented Jun 10, 2024

Ready for round-2

@kockan kockan requested a review from kachulis June 10, 2024 18:06
kachulis
kachulis reviewed Jun 10, 2024
View reviewed changes
@kockan kockan requested a review from kachulis June 11, 2024 12:55
kachulis
kachulis approved these changes Jun 11, 2024
View reviewed changes
Copy link
Collaborator

@kachulis kachulis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @kockan!

@kockan kockan merged commit 1e32078 into main Jun 11, 2024
5 checks passed
@kockan kockan deleted the can_prs_qc branch June 11, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kachulis kachulis kachulis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kockan @kachulis