Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plugin test failures #2109

Closed
wants to merge 3 commits into from
+4 −4
Closed

Fix plugin test failures #2109

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a46fc22
[Automated] Update the native jar versions
gimantha Nov 26, 2024
de3c6dc
[Automated] Update the native jar versions
gimantha Nov 26, 2024
a6152f9
Fix test failures
gimantha Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ballerina/Dependencies.toml
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@

[ballerina]
dependencies-toml-version = "2"
distribution-version = "2201.11.0-20241117-133400-a3054b77"
distribution-version = "2201.11.0-20241126-123300-03fa53fd"

[[package]]
org = "ballerina"
4 changes: 2 additions & 2 deletions ...lugin-tests/src/test/java/io/ballerina/stdlib/graphql/compiler/ServiceValidationTest.java
View file
Original file line number Diff line number Diff line change
@@ -985,7 +985,7 @@ public void testAnonymousRecordsAsFieldType() {

diagnostic = diagnosticIterator.next();
message = getErrorMessage(CompilationDiagnostic.INVALID_ANONYMOUS_FIELD_TYPE,
"record {|string name; int age;|}", "Query.class.profile");
"record {|string name; int age;|}", "Query.'class.profile");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This quote is invalid. Is there a place we missed to escape?

Suggested change
"record {|string name; int age;|}", "Query.'class.profile");
"record {|string name; int age;|}", "Query.class.profile");

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ThisaruGuruge, this is compile time error, as the resource path has the quote, it is now visible in errors also. Runtime behavior is not changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a discussion with @DimuthuMadushan .. will reevaluate

assertErrorMessage(diagnostic, message, 52, 23);

diagnostic = diagnosticIterator.next();
@@ -1044,7 +1044,7 @@ public void testInvalidUseOfReservedFederatedTypeNames() {
Iterator<Diagnostic> diagnosticIterator = diagnosticResult.errors().iterator();

Diagnostic diagnostic = diagnosticIterator.next();
String message = getErrorMessage(CompilationDiagnostic.INVALID_USE_OF_RESERVED_TYPE_AS_OUTPUT_TYPE, "Query.any",
String message = getErrorMessage(CompilationDiagnostic.INVALID_USE_OF_RESERVED_TYPE_AS_OUTPUT_TYPE, "Query.'any",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

"_Any");
assertErrorMessage(diagnostic, message, 43, 5);

2 changes: 1 addition & 1 deletion gradle.properties
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
org.gradle.caching=true
group=io.ballerina.stdlib
version=1.15.0-SNAPSHOT
ballerinaLangVersion=2201.11.0-20241117-133400-a3054b77
ballerinaLangVersion=2201.11.0-20241126-123300-03fa53fd

checkstylePluginVersion=10.12.0
spotbugsPluginVersion=6.0.18