Fix plugin test failures #2109
Closed
Fix plugin test failures #2109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimantha
requested review from
shafreenAnfar,
ThisaruGuruge,
DimuthuMadushan and
MohamedSabthar
as code owners
|
| @@ -985,7 +985,7 @@ public void testAnonymousRecordsAsFieldType() { | |||
|
|
|||
| diagnostic = diagnosticIterator.next(); | |||
| message = getErrorMessage(CompilationDiagnostic.INVALID_ANONYMOUS_FIELD_TYPE, | |||
| "record {|string name; int age;|}", "Query.class.profile"); | |||
| "record {|string name; int age;|}", "Query.'class.profile"); | |||
There was a problem hiding this comment.
This quote is invalid. Is there a place we missed to escape?
Suggested change
| "record {|string name; int age;|}", "Query.'class.profile"); | |
| "record {|string name; int age;|}", "Query.class.profile"); |
There was a problem hiding this comment.
@ThisaruGuruge, this is compile time error, as the resource path has the quote, it is now visible in errors also. Runtime behavior is not changed
There was a problem hiding this comment.
Had a discussion with @DimuthuMadushan .. will reevaluate
| @@ -1044,7 +1044,7 @@ public void testInvalidUseOfReservedFederatedTypeNames() { | |||
| Iterator<Diagnostic> diagnosticIterator = diagnosticResult.errors().iterator(); | |||
|
|
|||
| Diagnostic diagnostic = diagnosticIterator.next(); | |||
| String message = getErrorMessage(CompilationDiagnostic.INVALID_USE_OF_RESERVED_TYPE_AS_OUTPUT_TYPE, "Query.any", | |||
| String message = getErrorMessage(CompilationDiagnostic.INVALID_USE_OF_RESERVED_TYPE_AS_OUTPUT_TYPE, "Query.'any", | |||
gimantha
added
the
Skip GraalVM Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Relates to #2107
Examples
Checklist
commonspackage changes (if there are any, please update the GraphQL version in GraphQL tools and Ballerina dev tools)compilerpackage changes (if there are any, please update the GraphQL version in Ballerina dev tools)