-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added BBF hook to adjust numeric result to correct scale #529
Open
rohit01010
wants to merge
29
commits into
babelfish-for-postgresql:BABEL_5_X_DEV__PG_17_X
Choose a base branch
from
rohit01010:BABEL-5467
base: BABEL_5_X_DEV__PG_17_X
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added BBF hook to adjust numeric result to correct scale #529
rohit01010
wants to merge
29
commits into
babelfish-for-postgresql:BABEL_5_X_DEV__PG_17_X
from
rohit01010:BABEL-5467
+57
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Yvinayak07
reviewed
Feb 6, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
shah-nirmit
reviewed
Feb 12, 2025
@@ -762,6 +766,10 @@ ExecInterpExpr(ExprState *state, ExprContext *econtext, bool *isnull) | |||
} | |||
fcinfo->isnull = false; | |||
d = op->d.func.fn_addr(fcinfo); | |||
|
|||
if (sql_dialect == SQL_DIALECT_TSQL && bbf_trunc_numeric_result_hook) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: For every FuncExpr we will enter this hook, extra instructions for every expression evaluation, seems to me it will affect performance
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…nction Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
This was referenced Feb 21, 2025
Deepesh125
requested changes
Feb 22, 2025
Deepesh125
requested changes
Feb 23, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
shah-nirmit
approved these changes
Feb 26, 2025
Deepesh125
requested changes
Feb 27, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
surendravishnoi
previously approved these changes
Feb 27, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
surendravishnoi
previously approved these changes
Feb 28, 2025
Deepesh125
previously approved these changes
Mar 4, 2025
KushaalShroff
previously approved these changes
Mar 5, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
119177b
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For Babelfish, the expected behaviour should be for every arithmetic computation which results in numeric datatype, the result should be adjusted(truncated/rounded) to the correct scale. To get this behaviour added hooks at following places to adjust the result value.
Also,
T_OpExpr, T_DistinctExpr, T_CoerceViaIO
the result_typmod was directly hardcoded as-1
in PostgreSQL, Added hookpltsql_exprTypmod_hook
to compute the typmod of the expression and passed those instead of-1
to avoid losing typmod information.pltsql_exprTypmod_hook
to compute expression typmod for expressions whose typmod is not computed byexprTypmod
.ExecInitResultTypeTL
added hookExecUpdateResultTypeTL_hook
to set correct typmod of all attributes of result tuple.Extension PR: babelfish-for-postgresql/babelfish_extensions#3455
Issues Resolved
BABEL-5467
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the PostgreSQL license, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.