Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with truncation of result of arithmetic computations to correct scale when result is of numeric datatype #3455

Open
wants to merge 32 commits into
base: BABEL_5_X_DEV
Choose a base branch
from

Conversation

rohit01010
Copy link
Contributor

@rohit01010 rohit01010 commented Feb 5, 2025

Description

Currently, whenever an arithmetic operation is performed which results in numeric/decimal, we are storing the result till maximum possible scale instead of the correct scale. This is causing incorrect results in some arithmetic operations such as numeric division, numeric multiplication etc. This PR will fix this issue by adding a hooks in engine which truncates the result value to the correct scale and also sets the correct typmod of multiple nodes whose base type is NUMERIC.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#529

Issues Resolved

BABEL-5467

Test Scenarios Covered

  • Use case based -

  • Boundary conditions -

  • Arbitrary inputs -

  • Negative test cases -

  • Minor version upgrade tests -

  • Major version upgrade tests -

  • Performance tests -

  • Tooling impact -

  • Client tests -

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Rohit Bhagat added 3 commits February 5, 2025 11:54
… only

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Rohit Bhagat added 3 commits February 6, 2025 10:54
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…eric types

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
@coveralls
Copy link
Collaborator

coveralls commented Feb 7, 2025

Pull Request Test Coverage Report for Build 13696974677

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 143 of 178 (80.34%) changed or added relevant lines in 3 files are covered.
  • 277 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.05%) to 75.058%

Changes Missing Coverage Covered Lines Changed/Added Lines %
contrib/babelfishpg_tsql/src/hooks.c 49 53 92.45%
contrib/babelfishpg_tds/src/backend/tds/tdsresponse.c 93 124 75.0%
Files with Coverage Reduction New Missed Lines %
contrib/babelfishpg_common/src/varchar.c 19 85.15%
contrib/babelfishpg_tsql/src/pltsql_ruleutils.c 258 61.37%
Totals Coverage Status
Change from base Build 13569814182: 0.05%
Covered Lines: 47279
Relevant Lines: 62990

💛 - Coveralls

Rohit Bhagat added 4 commits February 10, 2025 05:43
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Rohit Bhagat added 10 commits February 12, 2025 11:34
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…desc with correct typmod in parallel mode for babelfish

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Rohit Bhagat added 6 commits February 27, 2025 12:09
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
@rohit01010 rohit01010 changed the title Added BBF hook to truncate numeric result to correct scale Fix issue with truncation of result of arithmetic computations to correct scale when result is of numeric datatype Feb 28, 2025
@shah-nirmit shah-nirmit self-requested a review March 3, 2025 05:52
@shah-nirmit shah-nirmit self-requested a review March 5, 2025 08:32
Comment on lines +1231 to +1237
rettypmod = resolve_numeric_typmod_from_exp(plan, (Node *) rlt->arg, &found_typmod);
if (!found_typmod)
{
if (found != NULL) *found = false;
return -1;
}
return rettypmod;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reusing the same piece of code everywhere, chance of encapsulating it?

KushaalShroff
KushaalShroff previously approved these changes Mar 5, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants