-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with truncation of result of arithmetic computations to correct scale when result is of numeric datatype #3455
Open
rohit01010
wants to merge
32
commits into
babelfish-for-postgresql:BABEL_5_X_DEV
Choose a base branch
from
rohit01010:BABEL-5467
base: BABEL_5_X_DEV
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
1 task
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
… only Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Yvinayak07
reviewed
Feb 6, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…eric types Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Pull Request Test Coverage Report for Build 13696974677Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
KushaalShroff
requested changes
Feb 12, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
…desc with correct typmod in parallel mode for babelfish Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Deepesh125
requested changes
Feb 22, 2025
Deepesh125
requested changes
Feb 23, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
shah-nirmit
approved these changes
Feb 26, 2025
Deepesh125
requested changes
Feb 27, 2025
test/JDBC/expected/non_default_server_collation/chinese_prc_ci_as/babel_datatype.out
Show resolved
Hide resolved
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
shah-nirmit
reviewed
Mar 5, 2025
Comment on lines
+1231
to
+1237
rettypmod = resolve_numeric_typmod_from_exp(plan, (Node *) rlt->arg, &found_typmod); | ||
if (!found_typmod) | ||
{ | ||
if (found != NULL) *found = false; | ||
return -1; | ||
} | ||
return rettypmod; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reusing the same piece of code everywhere, chance of encapsulating it?
KushaalShroff
previously approved these changes
Mar 5, 2025
Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, whenever an arithmetic operation is performed which results in numeric/decimal, we are storing the result till maximum possible scale instead of the correct scale. This is causing incorrect results in some arithmetic operations such as numeric division, numeric multiplication etc. This PR will fix this issue by adding a hooks in engine which truncates the result value to the correct scale and also sets the correct typmod of multiple nodes whose base type is
NUMERIC
.Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#529
Issues Resolved
BABEL-5467
Test Scenarios Covered
Use case based -
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.