Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Migrate from paste #723

Closed
wants to merge 1 commit into from
Closed

Conversation

justsmth
Copy link
Contributor

@justsmth justsmth commented Mar 7, 2025

Issues:

Addresses:

Context

The paste crate is no longer maintained.

Description of changes:

Migrate use of "paste" to concat-idents.

Callouts

  • Usage of the macros is nearly identical, except the constructed identity could not be used in another macro call to (e.g) stringify! or use_bindings!. Adjustments made accordingly.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth changed the title Migrate from paste [DRAFT] Migrate from paste Mar 7, 2025
@justsmth justsmth force-pushed the migrate-from-paste branch from 690f25f to 7c64225 Compare March 7, 2025 20:48
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.87%. Comparing base (c358484) to head (7c64225).
Report is 181 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #723      +/-   ##
==========================================
- Coverage   95.80%   92.87%   -2.93%     
==========================================
  Files          61       70       +9     
  Lines        8143     9566    +1423     
  Branches        0     9566    +9566     
==========================================
+ Hits         7801     8884    +1083     
- Misses        342      413      +71     
- Partials        0      269     +269     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jschwe
Copy link

jschwe commented Mar 10, 2025

concat_idents has not received any updates in 2 years and doesn't seem to be very popular either. I honestly think that migrating from paste to concat_idents would be a larger risk, since dependencies used in proc macros need to be trust worthy due to the lack of sandboxing.

@justsmth
Copy link
Contributor Author

concat_idents has not received any updates in 2 years and doesn't seem to be very popular either. I honestly think that migrating from paste to concat_idents would be a larger risk, since dependencies used in proc macros need to be trust worthy due to the lack of sandboxing.

I agree. I attempted a migration, in part, to see how extensive our use of paste is and how hard it might be to replace. The best way to resolve this issue might be to write our own proc macro that provides some basic functionality.

@justsmth justsmth closed this Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants