Added Docker::prune_build for /build/prune endpoint access
#509
+213
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fussybeaver
reviewed
Mar 6, 2025
Though BuildKit is not needed to prune the build cache, it is needed to write anything to the build cache in the first place, since the first-generation builder does not use it.
PruneBuildOptions should now be fully in line with the /build/prune endpoint. Remember kids: reading documentation saves lives!
How about reading your own code as well?
The strategy for using `df` has changed. Now it measures the difference in space taken up by the build cache before and after the `prune_build` instead of the build cache being at 0 bytes. Should make it consistent in a CI which may have dangling images holding into build cache.
|
Actually aligned the |
|
This looks great, I guess there's a new audit issue, which I need to take a look at Linked issue: aws/aws-lc-rs#722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the API that uses the
/build/pruneendpoint in Moby to clear the build cache (which powersdocker builder prune). I named the functionprune_buildand its options structPruneBuildOptions, in alignment with the other prune APIs (e.g.prune_containersandPruneContainersOptions). The already-existingBuildPruneResponseis used as the return type ofprune_build, so as to be useful.Relevant integration tests and examples updated.