Retain numeric parameter value type when creating open cypher query #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcginnes
reviewed
Jan 29, 2025
kmcginnes
reviewed
Jan 29, 2025
andreachild
force-pushed
the
paramTypeFix
branch
from
8c2dfb4 to
1e6099e
Compare
andreachild
changed the title
kmcginnes
reviewed
Jan 30, 2025
kmcginnes
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
Approving this smaller fix while we further investigate @danielfinke's more encompassing changes.
andreachild
force-pushed
the
paramTypeFix
branch
from
1e6099e to
e6f0f3b
Compare
Cole-Greer
approved these changes
Feb 4, 2025
…s strings upon conversion to the equivalent open cypher query. Fixed transformFunctionInputParameters which converts the graphQL request fields into a parameters object by converting the field value to a Number if the type is IntValue or FloatValue.
andreachild
force-pushed
the
paramTypeFix
branch
from
3be04a4 to
cc35aba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: #64
Description of changes:
Numeric graphQL query parameter values were inadvertently being set as strings upon conversion to the equivalent open cypher query. Fixed
transformFunctionInputParameterswhich converts the graphQL request fields into a parameters object by converting the field value to aNumberif the type isIntValueorFloatValue.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.