Don't cast integers to floats in Neptune schema #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test case for cast in `Case04.02` - update docs/samples/test cases closes aws#55
|
Hi @danielfinke I have a draft PR which is actually dependent on this fix you have made: #63 I made a similar fix in my draft but am hoping to get this PR reviewed and merged before mine and then I can rebase my branch off of your changes. |
andreachild
reviewed
Jan 29, 2025
|
@andreachild Awesome, I noticed the same issue re: input parameters being stored as strings, so that fix will be great to have |
andreachild
reviewed
Jan 29, 2025
|
LGTM thanks for fixing this! |
Cole-Greer
approved these changes
Jan 30, 2025
danielfinke
deleted the
dont-cast-integers-to-floats-in-neptune-schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #55
Description of changes:
Don't cast integers to floats in Neptune schema
Test case for cast in
Case04.02By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.