forked from tier4/awsim_sensor_kit_launch
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(awsim_labs_sensor_kit_launch): awsim lab load concatenate node parameters #9
Merged
xmfcx
merged 6 commits into
autowarefoundation:main
from
vividf:feature/awsim_lab_concatenate
Feb 13, 2025
Merged
feat(awsim_labs_sensor_kit_launch): awsim lab load concatenate node parameters #9
xmfcx
merged 6 commits into
autowarefoundation:main
from
vividf:feature/awsim_lab_concatenate
Feb 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@xmfcx |
When
|
1ebd714
to
cad0652
Compare
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
Signed-off-by: vividf <yihsiang.fang@tier4.jp>
a7066c3
to
ef6bd68
Compare
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
@xmfcx |
@xmfcx kindly ping |
xmfcx
approved these changes
Feb 13, 2025
xmfcx
pushed a commit
that referenced
this pull request
Feb 13, 2025
…arameters (#9) Signed-off-by: vividf <yihsiang.fang@tier4.jp>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
introduces a new concatenate algorithm and also removes the default parameter, thus the launcher would need to load the parameter from the parameter file.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.