refactor(behavior_velocity_planner_common): add behavior_velocity_rtc_interface and move RTC-related implementation #9799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:documentation
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
takayuki5168
force-pushed
the
feat/behavior-velocity-rtc-interface
branch
from
e67f34a to
41e85fa
Compare
takayuki5168
changed the title
Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com>
takayuki5168
force-pushed
the
feat/behavior-velocity-rtc-interface
branch
from
41e85fa to
3a65d75
Compare
takayuki5168
requested review from
satoshi-ota,
shmpwk,
tkimura4,
kosuke55,
soblin,
danielsanchezaran,
rej55,
yhisaki,
mehmetdogru,
mkuri,
TomohitoAndo,
isamu-takagi,
taikitanaka3,
maxime-clem,
TakaHoribe,
kyoichi-sugahara and
yuki-takagi-66
as code owners
takayuki5168
added
the
run:build-and-test-differential
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9799 +/- ##
==========================================
- Coverage 30.03% 30.01% -0.02%
==========================================
Files 1452 1459 +7
Lines 109043 109097 +54
Branches 42759 42763 +4
==========================================
- Hits 32748 32746 -2
- Misses 73095 73151 +56
Partials 3200 3200
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
soblin
reviewed
Dec 26, 2024
...terface/include/autoware/behavior_velocity_rtc_interface/scene_module_interface_with_rtc.hpp
Show resolved
Hide resolved
..._planner_common/include/autoware/behavior_velocity_planner_common/scene_module_interface.hpp
Show resolved
Hide resolved
|
LGTM |
…planner_common/include/autoware/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
…rtc_interface/include/autoware/behavior_velocity_rtc_interface/scene_module_interface_with_rtc.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
|
@soblin |
kminoda
pushed a commit
to kminoda/autoware.universe
that referenced
this pull request
Dec 27, 2024
…_interface and move RTC-related implementation (autowarefoundation#9799) * split into planer_common and rtc_interface Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/autoware_behavior_velocity_planner_common/include/autoware/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Update planning/behavior_velocity_planner/autoware_behavior_velocity_rtc_interface/include/autoware/behavior_velocity_rtc_interface/scene_module_interface_with_rtc.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Jan 6, 2025
…_interface and move RTC-related implementation (autowarefoundation#9799) * split into planer_common and rtc_interface Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> * Update planning/behavior_velocity_planner/autoware_behavior_velocity_planner_common/include/autoware/behavior_velocity_planner_common/scene_module_interface.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * Update planning/behavior_velocity_planner/autoware_behavior_velocity_rtc_interface/include/autoware/behavior_velocity_rtc_interface/scene_module_interface_with_rtc.hpp Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp> * fix Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> --------- Signed-off-by: Takayuki Murooka <takayuki5168@gmail.com> Co-authored-by: Mamoru Sobue <mamoru.sobue@tier4.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to split the tier4_msgs dependency from the pure behavior velocity planner 's common implementation, I split the behavior_velocity_planner_common into
The motivation is porting behavior_velocity_planner_common to Autoware.Core by removing the tier4_msgs dependency.
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.