Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_cuda_pointcloud_preprocessor): a cuda-accelerated pointcloud preprocessor #9454

Merge branch 'main' into feat/cuda_blackboard_pointcloud_preprocessing

2a1ff8c
Select commit
Loading
Failed to load commit list.
Merged

feat(autoware_cuda_pointcloud_preprocessor): a cuda-accelerated pointcloud preprocessor #9454

Merge branch 'main' into feat/cuda_blackboard_pointcloud_preprocessing
2a1ff8c
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Mar 18, 2025 in 41s

CodeScene PR Check

Quality Gate Failed

Gates Failed
New code is healthy (1 new file with code health below 9.00)
Enforce advisory code health rules (1 file with Complex Method, Complex Conditional)

Gates Passed
2 Quality Gates Passed

See analysis details in CodeScene

Reason for failure
New code is healthy Violations Code Health Impact
cuda_pointcloud_preprocessor_node.cpp 2 rules 10.00 → 8.77 Suppress
Enforce advisory code health rules Violations Code Health Impact
cuda_pointcloud_preprocessor_node.cpp 2 advisory rules 10.00 → 8.77 Suppress

Quality Gate Profile: Clean Code Collective
Want more control? Customize Code Health rules or catch issues early with our IDE extension and CLI tool.

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Conditional cuda_pointcloud_preprocessor_node.cpp: CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode
  • Complex Method cuda_pointcloud_preprocessor_node.cpp: CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode
  • Complex Method cuda_pointcloud_preprocessor_node.cpp: CudaPointcloudPreprocessorNode::pointcloudCallback

Annotations

Check warning on line 139 in sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 295 in sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Method

CudaPointcloudPreprocessorNode::pointcloudCallback has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 70 in sensing/autoware_cuda_pointcloud_preprocessor/src/cuda_pointcloud_preprocessor/cuda_pointcloud_preprocessor_node.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Complex Conditional

CudaPointcloudPreprocessorNode::CudaPointcloudPreprocessorNode has 1 complex conditionals with 4 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.