Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpp)!: remove stop reason #9449

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Nov 25, 2024

Description

Don't use stop reason. This module uses velocity factor instead of it.

Related links

Parent Issue:

  • Link

How was this PR tested?

Please confirm that this module doesn't output stop reason.

/planning/scenario_planning/status/stop_reasons

Notes for reviewers

After this PR, this module only outputs velocity/steering factors.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) labels Nov 25, 2024
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@satoshi-ota satoshi-ota changed the title fix(bpp): remove stop reason fix(bpp)!: remove stop reason Nov 25, 2024
@satoshi-ota satoshi-ota marked this pull request as ready for review November 25, 2024 08:58
@satoshi-ota satoshi-ota added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Nov 25, 2024
@satoshi-ota satoshi-ota enabled auto-merge (squash) November 25, 2024 09:12
@satoshi-ota satoshi-ota merged commit 9c6895b into autowarefoundation:main Nov 25, 2024
49 of 50 checks passed
@satoshi-ota satoshi-ota deleted the fix/remove-stop-reason branch November 25, 2024 09:45
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.04%. Comparing base (badf8ca) to head (636cfaa).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9449      +/-   ##
==========================================
- Coverage   29.06%   29.04%   -0.02%     
==========================================
  Files        1438     1444       +6     
  Lines      108434   108457      +23     
  Branches    41516    41507       -9     
==========================================
- Hits        31515    31504      -11     
- Misses      73879    73913      +34     
  Partials     3040     3040              
Flag Coverage Δ *Carryforward flag
differential 20.02% <ø> (?)
total 29.05% <ø> (-0.01%) ⬇️ Carriedforward from badf8ca

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants