feat(autoware_pointcloud_preprocessor): distortion corrector node update azimuth and distance #8380
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Aug 6, 2024 in 40s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.47 (8.09 -> 7.62)
- Declining Code Health: 3 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication test_distortion_corrector_node.cpp
- Complex Method distortion_corrector.cpp: undistortPointCloud
- Complex Method test_distortion_corrector_node.cpp: TEST:DistortionCorrectorTest:TestUndistortPointCloudNotUpdateAzimuthAndDistance
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
undistortPointCloud increases in cyclomatic complexity from 13 to 19, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Bumpy Road Ahead
undistortPointCloud increases from 2 to 3 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 48.65% to 50.00%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Code Duplication
introduced similar code in: TEST:DistortionCorrectorTest:TestUndistortPointCloudUpdateAzimuthAndDistanceInHesai,TEST:DistortionCorrectorTest:TestUndistortPointCloudUpdateAzimuthAndDistanceInVelodyne. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
TEST:DistortionCorrectorTest:TestUndistortPointCloudNotUpdateAzimuthAndDistance has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Loading