Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: perception objects pointcloud better visualization #8247

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

feat: refactor get_2d_shape_marker_ptr function to use TRIANGLE_LIST …

61dde06
Select commit
Loading
Failed to load commit list.
Draft

feat: perception objects pointcloud better visualization #8247

feat: refactor get_2d_shape_marker_ptr function to use TRIANGLE_LIST …
61dde06
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jul 29, 2024 in 35s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: -0.31 (8.16 -> 7.85)

  • Declining Code Health: 1 findings(s) 🚩
  • Improving Code Health: 1 findings(s) ✅

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Large Method object_polygon_detail.cpp: calc_2d_bounding_box_bottom_triangle_list

✅ Improving Code Health:

  • Primitive Obsession object_polygon_detail.cpp

Annotations

Check warning on line 676 in common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ New issue: Large Method

calc_2d_bounding_box_bottom_triangle_list has 70 lines, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.

Check notice on line 1 in common/autoware_perception_rviz_plugin/src/object_detection/object_polygon_detail.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

✅ Getting better: Primitive Obsession

The ratio of primitive types in function arguments decreases from 31.58% to 30.93%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.