Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions #7855

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 4, 2024

Description

This is a fix based on cppcheck warnings.

common/fake_test_node/test/test_fake_test_node.cpp:101:0: information: Unmatched suppression: syntaxError [unmatchedSuppression]
  ::testing::Values(-5, 0, 42));
^
common/osqp_interface/test/test_osqp_interface.cpp:41:0: information: Unmatched suppression: syntaxError [unmatchedSuppression]
TEST(TestOsqpInterface, BasicQp)
^
common/qp_interface/test/test_osqp_interface.cpp:41:0: information: Unmatched suppression: syntaxError [unmatchedSuppression]
TEST(TestOsqpInterface, BasicQp)
^
common/qp_interface/test/test_proxqp_interface.cpp:42:0: information: Unmatched suppression: syntaxError [unmatchedSuppression]
TEST(TestProxqpInterface, BasicQp)
^

There is no need to suppress cppcheck errors in test directories since they are out of scope of cppcheck CI.

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

… cppcheck inline suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:common Common packages from the autoware-common repository. (auto-assigned) label Jul 4, 2024
Copy link

github-actions bot commented Jul 4, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc self-assigned this Jul 4, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.64%. Comparing base (a195201) to head (84db1e1).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7855      +/-   ##
==========================================
- Coverage   28.65%   28.64%   -0.02%     
==========================================
  Files        1587     1592       +5     
  Lines      116361   116416      +55     
  Branches    49686    49688       +2     
==========================================
- Hits        33347    33346       -1     
- Misses      73974    74031      +57     
+ Partials     9040     9039       -1     
Flag Coverage Δ *Carryforward flag
differential 19.06% <ø> (?)
total 28.65% <ø> (-0.01%) ⬇️ Carriedforward from a195201

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc
Copy link
Contributor Author

veqcc commented Jul 5, 2024

@rej55 @maxime-clem @satoshi-ota @takayuki5168
Please approve it!!

@veqcc veqcc merged commit 3627afc into autowarefoundation:main Jul 5, 2024
30 checks passed
@veqcc veqcc deleted the fix/remove_cppcheck_inline_suppressions branch July 5, 2024 06:06
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
… cppcheck inline suppressions (autowarefoundation#7855)

* fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
… cppcheck inline suppressions (autowarefoundation#7855)

* fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
… cppcheck inline suppressions (#7855)

* fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
… cppcheck inline suppressions (autowarefoundation#7855)

* fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:common Common packages from the autoware-common repository. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants