-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions #7855
fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions #7855
Conversation
… cppcheck inline suppressions Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7855 +/- ##
==========================================
- Coverage 28.65% 28.64% -0.02%
==========================================
Files 1587 1592 +5
Lines 116361 116416 +55
Branches 49686 49688 +2
==========================================
- Hits 33347 33346 -1
- Misses 73974 74031 +57
+ Partials 9040 9039 -1
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rej55 @maxime-clem @satoshi-ota @takayuki5168 |
… cppcheck inline suppressions (autowarefoundation#7855) * fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: palas21 <palas21@itu.edu.tr>
… cppcheck inline suppressions (autowarefoundation#7855) * fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… cppcheck inline suppressions (#7855) * fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
… cppcheck inline suppressions (autowarefoundation#7855) * fix(fake_test_node, osqp_interface, qp_interface): remove unnecessary cppcheck inline suppressions Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> * style(pre-commit): autofix --------- Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Description
This is a fix based on cppcheck warnings.
There is no need to suppress cppcheck errors in
test
directories since they are out of scope of cppcheck CI.Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.