Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_planning_validator): fix knownConditionTrueFalse #7817

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 3, 2024

Description

This is a fix based on cppcheck knownConditionTrueFalse warning

planning/autoware_planning_validator/src/invalid_trajectory_publisher/invalid_trajectory_publisher.cpp:64:7: style: Condition 'EXIT_AFTER_PUBLISH' is always false [knownConditionTrueFalse]
  if (EXIT_AFTER_PUBLISH) {
      ^
planning/autoware_planning_validator/src/invalid_trajectory_publisher/invalid_trajectory_publisher.cpp:63:29: note: Assignment 'EXIT_AFTER_PUBLISH=false', assigned value is 0
  bool EXIT_AFTER_PUBLISH = false;
                            ^
planning/autoware_planning_validator/src/invalid_trajectory_publisher/invalid_trajectory_publisher.cpp:64:7: note: Condition 'EXIT_AFTER_PUBLISH' is always false
  if (EXIT_AFTER_PUBLISH) {
      ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@veqcc veqcc requested review from kosuke55 and TakaHoribe as code owners July 3, 2024 23:36
@veqcc veqcc self-assigned this Jul 3, 2024
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.67%. Comparing base (9e47b4d) to head (7096361).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7817      +/-   ##
==========================================
- Coverage   28.67%   28.67%   -0.01%     
==========================================
  Files        1587     1588       +1     
  Lines      116304   116325      +21     
  Branches    49656    49659       +3     
==========================================
+ Hits        33354    33360       +6     
- Misses      73891    73907      +16     
+ Partials     9059     9058       -1     
Flag Coverage Δ *Carryforward flag
differential 8.50% <ø> (?)
total 28.67% <ø> (ø) Carriedforward from 9e47b4d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit b233929 into autowarefoundation:main Jul 5, 2024
39 checks passed
@veqcc veqcc deleted the fix/cppcheck_knownConditionTrueFalse3 branch July 5, 2024 01:20
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…refoundation#7817)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants