Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_behavior_path_planner_common): fix knownConditionTrueFalse #7816

Merged

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jul 3, 2024

Description

This is a fix based on cppcheck knownConditionTrueFalse warning

planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_shifter/path_shifter.cpp:197:39: style: Condition 'shift_line.start_idx<=i' is always true [knownConditionTrueFalse]
      } else if (shift_line.start_idx <= i && i <= shift_line.end_idx) {
                                      ^
planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_shifter/path_shifter.cpp:195:13: note: Assuming that condition 'i<shift_line.start_idx' is not redundant
      if (i < shift_line.start_idx) {
            ^
planning/behavior_path_planner/autoware_behavior_path_planner_common/src/utils/path_shifter/path_shifter.cpp:197:39: note: Condition 'shift_line.start_idx<=i' is always true
      } else if (shift_line.start_idx <= i && i <= shift_line.end_idx) {
                                      ^

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jul 3, 2024
Copy link

github-actions bot commented Jul 3, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@veqcc veqcc self-assigned this Jul 3, 2024
@veqcc veqcc added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.66%. Comparing base (9e47b4d) to head (9189f08).
Report is 1 commits behind head on main.

Files Patch % Lines
...ner_common/src/utils/path_shifter/path_shifter.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7816      +/-   ##
==========================================
- Coverage   28.67%   28.66%   -0.02%     
==========================================
  Files        1587     1593       +6     
  Lines      116304   116349      +45     
  Branches    49656    49657       +1     
==========================================
  Hits        33354    33354              
- Misses      73891    73936      +45     
  Partials     9059     9059              
Flag Coverage Δ *Carryforward flag
differential 13.22% <0.00%> (?)
total 28.67% <ø> (+<0.01%) ⬆️ Carriedforward from 9e47b4d

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 96e616f into autowarefoundation:main Jul 4, 2024
39 checks passed
@veqcc veqcc deleted the fix/cppcheck_knownConditionTrueFalse2 branch July 4, 2024 00:08
palas21 pushed a commit to palas21/autoware.universe that referenced this pull request Jul 12, 2024
…se (autowarefoundation#7816)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Signed-off-by: palas21 <palas21@itu.edu.tr>
tby-udel pushed a commit to tby-udel/autoware.universe that referenced this pull request Jul 14, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…se (#7816)

Signed-off-by: Ryuta Kambe <ryuta.kambe@tier4.jp>
Ariiees pushed a commit to Ariiees/autoware.universe that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants