Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(raindrop_cluster_filter)!: fix namespace and directory structure #7785

Merged
merged 2 commits into from
Jul 3, 2024
+18 −17
Merged

refactor(raindrop_cluster_filter)!: fix namespace and directory structure #7785

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4522419
refactor: namespace fix, move header to src
technolojin Jul 2, 2024
b37438e
Merge branch 'main' into refactor/namespace-raindrop_cluster_filter
technolojin Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions perception/raindrop_cluster_filter/CMakeLists.txt
View file
Original file line number Diff line number Diff line change
@@ -10,11 +10,11 @@ autoware_package()

# Targets
ament_auto_add_library(low_intensity_cluster_filter SHARED
src/low_intensity_cluster_filter.cpp
src/low_intensity_cluster_filter_node.cpp
)

rclcpp_components_register_node(low_intensity_cluster_filter
PLUGIN "low_intensity_cluster_filter::LowIntensityClusterFilter"
PLUGIN "autoware::low_intensity_cluster_filter::LowIntensityClusterFilter"
EXECUTABLE low_intensity_cluster_filter_node)


12 changes: 7 additions & 5 deletions ...lter/src/low_intensity_cluster_filter.cpp → ...src/low_intensity_cluster_filter_node.cpp
View file
Original file line number Diff line number Diff line change
@@ -12,15 +12,17 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#include "raindrop_cluster_filter/low_intensity_cluster_filter/low_intensity_cluster_filter.hpp"
#include "low_intensity_cluster_filter_node.hpp"

#include "autoware/universe_utils/geometry/geometry.hpp"

#include <autoware/universe_utils/geometry/geometry.hpp>
#include <pcl_ros/transforms.hpp>

#include <sensor_msgs/point_cloud2_iterator.hpp>

#include <pcl_conversions/pcl_conversions.h>
namespace low_intensity_cluster_filter

namespace autoware::low_intensity_cluster_filter
{
LowIntensityClusterFilter::LowIntensityClusterFilter(const rclcpp::NodeOptions & node_options)
: Node("low_intensity_cluster_filter_node", node_options),
@@ -135,7 +137,7 @@ bool LowIntensityClusterFilter::isValidatedCluster(const sensor_msgs::msg::Point
return false;
}

} // namespace low_intensity_cluster_filter
} // namespace autoware::low_intensity_cluster_filter

#include <rclcpp_components/register_node_macro.hpp>
RCLCPP_COMPONENTS_REGISTER_NODE(low_intensity_cluster_filter::LowIntensityClusterFilter)
RCLCPP_COMPONENTS_REGISTER_NODE(autoware::low_intensity_cluster_filter::LowIntensityClusterFilter)
19 changes: 9 additions & 10 deletions ...r_filter/low_intensity_cluster_filter.hpp → ...src/low_intensity_cluster_filter_node.hpp
View file
Original file line number Diff line number Diff line change
@@ -12,26 +12,25 @@
// See the License for the specific language governing permissions and
// limitations under the License.

#ifndef RAINDROP_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER_HPP_
#define RAINDROP_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER_HPP_
#ifndef LOW_INTENSITY_CLUSTER_FILTER_NODE_HPP_
#define LOW_INTENSITY_CLUSTER_FILTER_NODE_HPP_

#include "autoware/universe_utils/ros/debug_publisher.hpp"
#include "autoware/universe_utils/system/stop_watch.hpp"
#include "detected_object_validation/utils/utils.hpp"

#include <autoware/universe_utils/ros/debug_publisher.hpp>
#include <autoware/universe_utils/system/stop_watch.hpp>
#include <Eigen/Eigen>
#include <rclcpp/rclcpp.hpp>

#include <tier4_perception_msgs/msg/detected_objects_with_feature.hpp>
#include "tier4_perception_msgs/msg/detected_objects_with_feature.hpp"

#include <tf2_ros/buffer.h>
#include <tf2_ros/transform_listener.h>
// #include <tf2_eigen/tf2_eigen.hpp>
#include <Eigen/Eigen>

#include <memory>
#include <string>

namespace low_intensity_cluster_filter
namespace autoware::low_intensity_cluster_filter
{

class LowIntensityClusterFilter : public rclcpp::Node
@@ -73,6 +72,6 @@ class LowIntensityClusterFilter : public rclcpp::Node
std::unique_ptr<autoware::universe_utils::DebugPublisher> debug_publisher_ptr_{nullptr};
};

} // namespace low_intensity_cluster_filter
} // namespace autoware::low_intensity_cluster_filter

#endif // RAINDROP_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER__LOW_INTENSITY_CLUSTER_FILTER_HPP_
#endif // LOW_INTENSITY_CLUSTER_FILTER_NODE_HPP_