feat(default_ad_api_helpers): use polling subscriber #7416
Closed
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
succeeded
Jun 10, 2024 in 48s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 3 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Complex Conditional routing_adaptor.cpp: RoutingAdaptor::on_timer
- Complex Method routing_adaptor.cpp: RoutingAdaptor::on_timer
- Bumpy Road Ahead routing_adaptor.cpp: RoutingAdaptor::on_timer
Annotations
Check warning on line 79 in system/default_ad_api_helpers/ad_api_adaptors/src/routing_adaptor.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
RoutingAdaptor::on_timer has a cyclomatic complexity of 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 53 in system/default_ad_api_helpers/ad_api_adaptors/src/routing_adaptor.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
RoutingAdaptor::on_timer has 1 complex conditionals with 3 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
Check warning on line 79 in system/default_ad_api_helpers/ad_api_adaptors/src/routing_adaptor.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
RoutingAdaptor::on_timer has 3 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Loading