Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(planning_validator): use polling subscriber #7356

Conversation

kyoichi-sugahara
Copy link
Contributor

Description

The same as this PR based on the discussion, the polling subscriber is used in the obstacle_avoidance_planner.

after the PR is merged

Tests performed

check psim and echo topic with following command

ros2 topic echo /planning/autoware_planning_validator/validation_status

get the following output

---
stamp:
  sec: 1717738132
  nanosec: 36705836
is_valid_size: true
is_valid_finite_value: true
is_valid_interval: true
is_valid_relative_angle: true
is_valid_curvature: true
is_valid_lateral_acc: true
is_valid_longitudinal_max_acc: true
is_valid_longitudinal_min_acc: true
is_valid_steering: true
is_valid_steering_rate: true
is_valid_velocity_deviation: true
is_valid_distance_deviation: true
is_valid_longitudinal_distance_deviation: true
is_valid_forward_trajectory_length: true
trajectory_size: 162
max_interval_distance: 1.0000000358459422
max_relative_angle: 0.00020640208742839228
max_curvature: 0.0001376013912444474
max_lateral_acc: 0.004167162866877597
max_longitudinal_acc: 1.0023255348205566
min_longitudinal_acc: 0.0
max_steering: 0.0003839078627112221
max_steering_rate: 0.001138575508739542
velocity_deviation: 0.2500005066394806
distance_deviation: 0.16999918825570942
longitudinal_distance_deviation: 0.0
forward_trajectory_length_required: 0.0
forward_trajectory_length_measured: 0.0
invalid_count: 0
---

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 7, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/use-polling-subscriber-planning_validator branch from 5aa20fa to aacc894 Compare June 7, 2024 07:25
kyoichi-sugahara and others added 3 commits June 7, 2024 16:27
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/use-polling-subscriber-planning_validator branch from aacc894 to e2067a5 Compare June 7, 2024 07:27
Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
@github-actions github-actions bot removed type:documentation Creating or refining documentation. (auto-assigned) component:launch Launch files, scripts and initialization tools. (auto-assigned) labels Jun 7, 2024
@kyoichi-sugahara kyoichi-sugahara force-pushed the feat/use-polling-subscriber-planning_validator branch from e2067a5 to 55d6564 Compare June 7, 2024 07:29
@kyoichi-sugahara kyoichi-sugahara added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 10, 2024
@kyoichi-sugahara kyoichi-sugahara merged commit 40cc412 into autowarefoundation:main Jun 10, 2024
32 of 33 checks passed
@kyoichi-sugahara kyoichi-sugahara deleted the feat/use-polling-subscriber-planning_validator branch June 10, 2024 08:20
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
* use polling subscriber

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>

---------

Signed-off-by: kyoichi-sugahara <kyoichi.sugahara@tier4.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants