Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(no_stopping_area): skip drawing a stop line in the case where the detected stop lines are goals #7280

Merged
merged 5 commits into from
Jun 14, 2024

Merge branch 'awf-latest' into revert-no-stopping-area-module

79e5b56
Select commit
Loading
Failed to load commit list.
Merged

fix(no_stopping_area): skip drawing a stop line in the case where the detected stop lines are goals #7280

Merge branch 'awf-latest' into revert-no-stopping-area-module
79e5b56
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main) failed Jun 14, 2024 in 30s

CodeScene PR Check

❌ Code Health Quality Gates: FAILED

  • Declining Code Health: 1 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Complex Method scene_no_stopping_area.cpp: NoStoppingAreaModule::generateEgoNoStoppingAreaLanePolygon

Annotations

Check warning on line 345 in planning/autoware_behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

❌ Getting worse: Complex Method 

NoStoppingAreaModule::generateEgoNoStoppingAreaLanePolygon increases in cyclomatic complexity from 12 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 1 in planning/autoware_behavior_velocity_no_stopping_area_module/src/scene_no_stopping_area.cpp

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)

ℹ Getting worse: Overall Code Complexity 

The mean cyclomatic complexity increases from 6.44 to 6.67, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
View more details on CodeScene Delta Analysis