feat(surround_obstacle_checker): use polling subscriber #7215
+11
−30
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Jun 5, 2024 in 50s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 1 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity node.cpp
✅ Improving Code Health:
- Large Method node.cpp: SurroundObstacleCheckerNode::SurroundObstacleCheckerNode
Annotations
Check notice on line 277 in planning/surround_obstacle_checker/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
ℹ Getting worse: Complex Method
SurroundObstacleCheckerNode::onTimer already has high cyclomatic complexity, and now it increases in Lines of Code from 73 to 76. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check warning on line 1 in planning/surround_obstacle_checker/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 4.33 across 15 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 208 in planning/surround_obstacle_checker/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Large Method
SurroundObstacleCheckerNode::SurroundObstacleCheckerNode is no longer above the threshold for lines of code
Loading