Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ndt_scan_matcher): remove unused dependency #7185

Conversation

a-maumau
Copy link
Contributor

@a-maumau a-maumau commented May 31, 2024

Description

This PR is for removing the unused dependency in ndt_scan_matcher/package.xml which should be removed in the #7130

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@github-actions github-actions bot added the component:localization Vehicle's position determination in its environment. (auto-assigned) label May 31, 2024
@SakodaShintaro SakodaShintaro added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label May 31, 2024
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have confirmed that logging_simulator works.
👍

@SakodaShintaro SakodaShintaro merged commit 0f1ae3e into autowarefoundation:main May 31, 2024
39 checks passed
karishma1911 pushed a commit to Interplai/autoware.universe that referenced this pull request Jun 3, 2024
)

rm unused dependency

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
a-maumau added a commit to a-maumau/autoware.universe that referenced this pull request Jun 7, 2024
)

rm unused dependency

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
@a-maumau a-maumau deleted the mau/fix/localization/ndt_scan_matcher branch July 22, 2024 06:17
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
rm unused dependency

Signed-off-by: a-maumau <maumaumaumaumaumaumaumaumaumau@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants